Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to micronaut 3 #160

Merged
merged 5 commits into from
Jun 29, 2021
Merged

upgrade to micronaut 3 #160

merged 5 commits into from
Jun 29, 2021

Conversation

grimmjo
Copy link
Collaborator

@grimmjo grimmjo commented Jun 23, 2021 •
edited by ilopmar
Loading

  • adds jakarta.inject:jakarta.inject-api:2.0.0
  • bump jnats version from 2.11.1 to 2.11.4

fixes #159

@grimmjo grimmjo requested a review from ilopmar June 23, 2021 11:41
@ilopmar
Copy link
Contributor

ilopmar commented Jun 25, 2021

Thanks for doing this. I'll review it next week.

ilopmar
ilopmar suggested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@ilopmar ilopmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Besides my 2 minor comments you need to switch the Reactor in the Java code and probably modify the existing tests to use Mono/Flux besides the RxJava2 types.

@ilopmar ilopmar mentioned this pull request Jun 28, 2021
Closed
grimmjo and others added 4 commits June 28, 2021 11:59
@grimmjo
upgrade to micronaut 3
4f309c3 
adds jakarta.inject:jakarta.inject-api:2.0.0
bump jnats version from 2.11.1 to 2.11.4

fixes #173
@grimmjo
code review fixes
3ad364b
@grimmjo
migrate from rxjava2 to micronaut-reactor
1553bd9
@grimmjo
migrate from @Body to @MessageBody
c95fd2c
@grimmjo
Copy link
Collaborator Author

grimmjo commented Jun 28, 2021 •
edited
Loading

@ilopmar I've migrated from rxjava2 to micronaut-reactor and also from @Body to @MessageBody

ilopmar
ilopmar suggested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@ilopmar ilopmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more minor thing and I'll approve it. Then I'll release a milestone version.

@grimmjo grimmjo requested a review from ilopmar June 28, 2021 16:16
@grimmjo
Copy link
Collaborator Author

grimmjo commented Jun 28, 2021

Thanks for releasing the milestone version. Do you also release the major version later?

@ilopmar ilopmar merged commit 09dcdf3 into master Jun 29, 2021
@ilopmar ilopmar deleted the upgradeToMN3 branch June 29, 2021 07:41
@ilopmar
Copy link
Contributor

ilopmar commented Jun 29, 2021

Thanks for releasing the milestone version. Do you also release the major version later?

Yes, I'll take care of all releases.

Thanks again for your help on this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopmar ilopmar ilopmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release a new version compatible with Micronaut 3.0
2 participants
@grimmjo @ilopmar