Fix build failures when Docker auth check fails

[eager-signal]

fixes #1172

[CLAassistant]

All committers have signed the CLA.

[sdelamo]

can you add a test?

[eager-signal]

can you add a test?

@sdelamo done. I confirmed that the test fails without the change and passes afterward.

[eager-signal]

This test could be revised to be confirm a successful push after the soft failure, if there is a GCR analog to phx.ocir.io/oraclelabs/micronaut-maven-plugin available.

[alvarosanchez]

@eager-signal I'm testing this locally, and am getting the same error as in CI: DockerService#getAuthConfigFor is not even called (credential is null), so the check you added there is not having any effect.

Maybe you're logged in locally and you are getting different results?

[eager-signal]

Maybe you're logged in locally and you are getting different results?

@alvarosanchez ah, this is possible. I will do some testing in a clean environment.

[eager-signal]

Maybe you're logged in locally and you are getting different results?

@alvarosanchez thanks for the tip. I cleared my ~/.docker/config.json locally, and that was indeed the issue. (There was also a second issue—now that testcontainers 1.20.3 is out with its bug fixed, the soft failure was also gone when my credentials were present.)

I just pushed an update to the gh1172-deploy integration test with some invalid credentials, so now it should fail without the fix, and pass correctly with the fix. I also added an integration test for the bug’s package case.

[eager-signal]

Hmm, the issue1172-package test passes for me locally with an empty ~/.docker/config.json—I wonder if there’s some default credentials for Docker Hub being discovered. In any case, I pushed a change to use a different registry, the GCR cache, as the image source.