Ensure reactive context is propagated #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultGraphQLInvocation and DefaultGraphQLExecutionInputCustomizer are updated to use Mono and Flux in their internal implementation in order to ensure that the Micronaut PropagationContext is carried appropriately through the invocation flow. Previous use of the bare io.micronaut.core.async.publisher.Publishers API in DefaultGraphQLExecutionInputCustomizer was causing the context not to be propagated as desired when including the Micrometer Context Propagation library. A test is added to verify the context propagation works as expected. Some additional cleanup is done throughout the test suite to reduce the scope of included Micronaut beans to the specific tests in order to make it easier to test different setups. Resolves #495
sdelamo
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Looking good.
Can we rewrite the snippets:
ApplicationContext context = new DefaultApplicationContext(Environment.TEST)
context.environment.addPropertySource(PropertySource.of(
["spec.name": GraphQLConfigurationSpec.simpleName,
"graphql.graphiql.enabled": false]
))
context.start()with:
ApplicationContext context = ApplicationContext.run(["spec.name": GraphQLConfigurationSpec.simpleName, "graphql.graphiql.enabled": false])I don't think we should be using DefaultApplicationContext class directly which is an internal class.
timyates
previously approved these changes
Mar 6, 2024
Agreed, good point. Done in 5ebb76d |
|
sdelamo
approved these changes
Mar 7, 2024
timyates
approved these changes
Mar 7, 2024
sdelamo
pushed a commit
that referenced
this pull request
Mar 7, 2024
DefaultGraphQLInvocation and DefaultGraphQLExecutionInputCustomizer are updated to use Mono and Flux in their internal implementation in order to ensure that the Micronaut PropagationContext is carried appropriately through the invocation flow. Previous use of the bare io.micronaut.core.async.publisher.Publishers API in DefaultGraphQLExecutionInputCustomizer was causing the context not to be propagated as desired when including the Micrometer Context Propagation library. A test is added to verify the context propagation works as expected. Some additional cleanup is done throughout the test suite to reduce the scope of included Micronaut beans to the specific tests in order to make it easier to test different setups. * Avoid direct instantiation of DefaultApplicationContext Resolves #495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultGraphQLInvocationandDefaultGraphQLExecutionInputCustomizerare updated to use Mono and Flux in their internal implementation in order to ensure that the MicronautPropagationContextis carried appropriately through the invocation flow. Previous use of the bareio.micronaut.core.async.publisher.PublishersAPI inDefaultGraphQLExecutionInputCustomizerwas causing the context not to be propagated as desired when including the Micrometer Context Propagation library.A test is added to verify the context propagation works as desired.
Some additional cleanup is done throughout the test suite to reduce the scope of included Micronaut beans to the specific tests in order to make it easier to test different setups.
Resolves #495