Skip to content

Commit

Permalink
Update common files
Browse files Browse the repository at this point in the history
  • Loading branch information
micronaut-build committed Feb 15, 2021
1 parent d5cc35e commit e286b40
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 52 deletions.
31 changes: 0 additions & 31 deletions .github/workflows/bintray-publish.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/central-sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
run: |
echo $GPG_FILE | base64 -d > secring.gpg
if [ -z ${PUBLISH_IN_2_STEPS+x} ]; then
./gradlew publish closeAndReleaseRepository
./gradlew publishToSonatype closeAndReleaseSonatypeStagingRepository
else
./gradlew publish && ./gradlew closeAndReleaseRepository
./gradlew publishToSonatype && ./gradlew closeAndReleaseSonatypeStagingRepository
fi
2 changes: 1 addition & 1 deletion .github/workflows/dependency-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Check Dependencies
run: ./gradlew useLatestVersions
- name: Create Pull Request
uses: peter-evans/[email protected].1
uses: peter-evans/[email protected].2
with:
token: ${{ secrets.GH_TOKEN }}
committer: micronaut-build <${{ secrets.MICRONAUT_BUILD_EMAIL }}>
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ jobs:
run: ./gradlew dependencyUpdates check --parallel --continue
env:
TESTCONTAINERS_RYUK_DISABLED: true
- name: Publish to JFrog OSS
- name: Publish to Sonatype Snapshots
if: success() && github.event_name == 'push' && matrix.java == '8'
env:
BINTRAY_USER: ${{ secrets.BINTRAY_USER }}
BINTRAY_KEY: ${{ secrets.BINTRAY_KEY }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
run: ./gradlew publish docs --no-daemon
- name: Determine docs target repository
uses: haya14busa/action-cond@v1
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,8 @@ jobs:
MICRONAUT_BUILD_EMAIL: ${{ secrets.MICRONAUT_BUILD_EMAIL }}
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: Upload to Bintray
env:
BINTRAY_USER: ${{ secrets.BINTRAY_USER }}
BINTRAY_KEY: ${{ secrets.BINTRAY_KEY }}
BINTRAY_PUBLISH: ${{ secrets.BINTRAY_PUBLISH }}
run: ./gradlew bintrayUpload docs
- name: Generate docs
run: ./gradlew docs
- name: Export Gradle Properties
uses: micronaut-projects/github-actions/export-gradle-properties@master
- name: Publish to Github Pages
Expand Down
10 changes: 1 addition & 9 deletions MAINTAINING.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ source of truth for certain files. It is used as a template to create new repos,
template repo will get propagated automatically. The files propagated are:

* Workflow files (`.github/workflows/*`). They are copied using rsync"
* `bintray-publish.yml`.
* `central-sync.yml`.
* `dependency-update.yml`.
* `graalvm.yml`.
Expand Down Expand Up @@ -175,23 +174,16 @@ will kick off, performing the following steps:

* Pre-release: sets the `projectVersion` property in `gradle.properties` to the release version, and commit and pushes
the result.
* Uploads and publishes to Bintray.
* Generates documentation guide and publishes it to the `gh-pages` branch.
* Sends a pull request to Core to update the BOM.
* Post-release:
* Determines the next patch version, and sets it as a `SNAPSHOT` version.
* Closes the milestone that matches the release version, and creates a new one for the next patch.

Note that there are repos (like Core, that has a lot of modules) where uploading and publishing in the same Gradle execution
fails. If you want to upload, but not publish, define a repo secret `BINTRAY_PUBLISH` and set its value to `false`. Then,
once the release workflow has finished, you need to manually trigger the Bintray Publish workflow through the GitHub UI.

If everything goes well, you now need to manually trigger the Maven Central publishing workflow via the GitHub UI.

If there is an issue with the release, it's important not to trigger the Maven Central publishing workflow because once
we publish a version to Maven Central we cannot change or remove it anymore. On the other hand, if something failed during
the Bintray upload, docs publication,... we can manually log in into Bintray UI, delete the artifacts, and then restart
the workflow.
we publish a version to Maven Central we cannot change or remove it anymore.

There are some properties in `gradle.properties` that affect the release process:

Expand Down

0 comments on commit e286b40

Please sign in to comment.