Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for VirtualThreadMetrics #5610

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add docs for VirtualThreadMetrics #5610

merged 1 commit into from
Oct 31, 2024
+11 −0

Conversation

jonatan-ivanov
Copy link
Member

See #5067

@jonatan-ivanov jonatan-ivanov added the doc-update A documentation update label Oct 28, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.14.0 GA milestone Oct 28, 2024
shakuzen
shakuzen requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to mention somehow that VirtualThreadMetrics is in the micrometer-java21 module, so users know they need to add that dependency to use it. Maybe putting it in a different section/paragraph than the other things would be better in this sense.

@jonatan-ivanov
Copy link
Member Author

👍🏼 I moved it to a separate section.

@shakuzen shakuzen merged commit ea173cc into micrometer-metrics:main Oct 31, 2024
7 checks passed
@jonatan-ivanov jonatan-ivanov deleted the virtual-threads-docs branch October 31, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
doc-update A documentation update
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatan-ivanov @shakuzen