Announce OtlpMeterRegistry configuration found at startup #4830
Conversation
|
@climategadgets Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@climategadgets This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
shakuzen
changed the title
shakuzen
added
enhancement
| } | ||
|
|
||
| private void sayHello() { | ||
| logger.info("Publishing metrics for {} to {} with resource attributes {}", getClass().getSimpleName(), |
There was a problem hiding this comment.
Right now this will result in two log messages on start. One from PushMeterRegistry like:
publishing metrics for OtlpMeterRegistry every 1m
And now this also.
Publishing metrics for OtlpMeterRegistry to http://localhost:50901/v1/metrics with resource attributes {}
I think it may be confusing to users to see both messages. They may think two registries are publishing. I'll open a proposal to make the log message on start from PushMeterRegistry customizable and then this can be rebased on top of that if we merge it.
There was a problem hiding this comment.
#4848 is now merged and these changes can be adapted to use that.
Rather than log an additional message, customize the existing start log message.
shakuzen
force-pushed
the
issues/4828-say-hello
branch
from
158b0ae to
2be2173
Compare
Existing Behavior
OtlpMeterRegistrysays nothing at startup.Updated Behavior
OtlpMeterRegistryemits a startup message allowing to identify and troubleshoot the OTLP receiver endpoint.Additional Context
#4693
@pivotal-cla This is an Obvious Fix