remove metrics from MeterRegistry when shutting down InstrumentedQueuedThreadPool #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
changed the title
wakingrufus
force-pushed
the
cleanup-jetty-metrics
branch
from
1351b4d to
95fff2b
Compare
|
Hi @shakuzen would you mind taking a look at this PR? Thanks |
|
@jonatan-ivanov I would really appreciate if someone could take a look at this PR. Thanks! |
shakuzen
requested changes
Feb 5, 2024
...e/src/main/java/io/micrometer/core/instrument/binder/jetty/InstrumentedQueuedThreadPool.java
Outdated
Show resolved
Hide resolved
wakingrufus
force-pushed
the
cleanup-jetty-metrics
branch
from
95fff2b to
17f3c8f
Compare
wakingrufus
force-pushed
the
cleanup-jetty-metrics
branch
from
17f3c8f to
cd06911
Compare
shakuzen
requested changes
Feb 6, 2024
...e/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyServerThreadPoolMetrics.java
Outdated
Show resolved
Hide resolved
wakingrufus
force-pushed
the
cleanup-jetty-metrics
branch
2 times, most recently
from
a13d34b to
1c3c2ed
Compare
...e/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyServerThreadPoolMetrics.java
Show resolved
Hide resolved
...c/test/java/io/micrometer/core/instrument/binder/jetty/InstrumentedQueuedThreadPoolTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/io/micrometer/core/instrument/binder/jetty/InstrumentedQueuedThreadPoolTest.java
Outdated
Show resolved
Hide resolved
wakingrufus
force-pushed
the
cleanup-jetty-metrics
branch
from
1c3c2ed to
0e9977c
Compare
…dPoolMetrics/InstrumentedQueuedThreadPool fixes micrometer-metrics#4000
wakingrufus
force-pushed
the
cleanup-jetty-metrics
branch
from
0e9977c to
b365e4c
Compare
|
I have made all requested changes. Please take another look. |
shakuzen
approved these changes
Feb 9, 2024
|
Thank you for the pull request and patience and all the quick turnarounds on feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove metrics from MeterRegistry when shutting down JettyServerThreadPoolMetrics/InstrumentedQueuedThreadPool
fixes #4000
Rationale
Clean up resources when not needed anymore
Additional context
The dropwizard metrics jetty InstrumentedQueuedThreadPool does something similar, and it seems like a good idea to do here as well.