-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use elastic create operation instead of index #2997
Conversation
@jeremyross Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@jeremyross Thank you for signing the Contributor License Agreement! |
Is this a breaking change for users not using data streams? |
No, it's completely transparent. I've tested this change with indexes and data streams. The index name specified can be an index or a data stream. And if no index or data stream exists, elastic will create one and the matching index template determines whether an index or data stream is created. |
I don't know why the CI wasn't run for this pull request, but unit tests need to be updated for this change. They are failing now. |
Hello @jeremyross , Hope this message finds you well. I took the latest builds of micrometer, from 1.10 all the way to the latest milestone. I am observing the following: those are facts and observations:
Above, for test cases 1, 2, and 3, by plain index, I mean this: (please see screenshot) and by data stream I mean this (please see screenshot) (small nota, your change is great for test case 2. Without your/this change, test case 2 would fail, I just verified) Just wanted to confirm with you this is your expectation for the above test cases. I am reaching out because for test 3, an expected enhancement/feature would be: if the index does not already exist, meaning the index does not even exist in the first place, neither plain index, neither data stream, micrometer will publish the metrics, and a time series data stream will be created, that would be a great feature. What do you think? Finally, would you mind sharing the data stream index template for the micrometer metrics please? Thank you for your time reading me. |
create
makes more sense and allows micrometer to write to elastic data streams.Closes #2996