Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a skip predicate to the TimedAspect and CountedAspect #2551

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Introduce a skip predicate to the TimedAspect and CountedAspect #2551

merged 5 commits into from
Apr 9, 2021

Conversation

jonatan-ivanov
Copy link
Member

So that users can skip Timer creation based on the JoinPoint, fixes gh-780

@jonatan-ivanov jonatan-ivanov requested a review from shakuzen April 8, 2021 06:04
@jonatan-ivanov jonatan-ivanov self-assigned this Apr 8, 2021
shakuzen
shakuzen reviewed Apr 8, 2021
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add more explanation on why someone would want to use the skip predicate so it can be more organically discovered. Other than that, seems like a good addition.

@jonatan-ivanov jonatan-ivanov marked this pull request as ready for review April 8, 2021 22:46
@jonatan-ivanov jonatan-ivanov requested a review from shakuzen April 8, 2021 22:47
@jonatan-ivanov jonatan-ivanov linked an issue Apr 8, 2021 that may be closed by this pull request
TimedAspect creates duplicates the metrics when spring already register it #2524
Closed
@jonatan-ivanov jonatan-ivanov changed the title Introducing a skip predicate to the TimedAspect Introducing a skip predicate to the TimedAspect and CountedAspect Apr 8, 2021
shakuzen
shakuzen approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shakuzen shakuzen changed the title Introducing a skip predicate to the TimedAspect and CountedAspect Introduce a skip predicate to the TimedAspect and CountedAspect Apr 9, 2021
@shakuzen shakuzen added the enhancement A general enhancement label Apr 9, 2021
@shakuzen shakuzen added this to the 1.7.0-RC1 milestone Apr 9, 2021
@shakuzen shakuzen merged commit f96b20b into master Apr 9, 2021
@shakuzen shakuzen deleted the aspect-filter branch April 9, 2021 01:51
@shakuzen shakuzen mentioned this pull request Apr 9, 2021
Closed
izeye added a commit to izeye/micrometer that referenced this pull request Apr 10, 2021
@izeye
Polish aspect changes
1b01022 
See micrometer-metricsgh-2551
@izeye izeye mentioned this pull request Apr 10, 2021
Merged
jonatan-ivanov pushed a commit that referenced this pull request Apr 10, 2021
@izeye
Polish aspect changes (#2556)
ae14e41 
See gh-2551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees

@jonatan-ivanov jonatan-ivanov

Labels
enhancement A general enhancement
Projects
None yet
Milestone
1.7.0-RC1
2 participants
@jonatan-ivanov @shakuzen