Ignore METHOD_NEW_DEFAULT binary compatibility #3181
Labels
Milestone
Comments
shakuzen
added a commit
to shakuzen/micrometer
that referenced
this issue
May 16, 2022
Manually exclude the new method since we cannot easily exclude the new default method check in the current version of the gradle plugin. See micrometer-metricsgh-3181.
|
We can now do this more easily thanks to melix/japicmp-gradle-plugin#43 being implemented. I've also updated it to target 1.8.x since japicmp was backported there since this issue was opened. |
izeye
added a commit
to izeye/micrometer
that referenced
this issue
Sep 27, 2022
This commit also replaces method excludes with METHOD_NEW_DEFAULT compatibility change exclude. Closes micrometer-metricsgh-3181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We check binary compatibility in the build against the previous version to catch incompatibilities introduced. This catches new default methods on interfaces, which we don't want blocking the build, since we expect this to be compatible. This came up in #3175 (comment). It was brought up in the
japicmprepo in siom79/japicmp#201. However, it looks like we're missing a straightforward way to configure acceptingMETHOD_NEW_DEFAULTchanges in the Gradle plugin. It has been requested in melix/japicmp-gradle-plugin#43. We may have to do a temporary workaround until that is resolved.The text was updated successfully, but these errors were encountered: