Skip to content

Commit

Permalink
Remove conditional check for disabling japicmp in otlp
Browse files Browse the repository at this point in the history
The version is not determined correctly in release builds from tags. It ends up being `1.10.0-SNAPSHOT` for instance, when doing a patch release of 1.9.x. We could probably rework the release process to avoid this issue, but this change is less risky given we are trying to do a release now.

Workaround due to problem described in gh-3408
  • Loading branch information
shakuzen committed Sep 12, 2022
1 parent 134dca6 commit aa5be1e
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions implementations/micrometer-registry-otlp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ dependencies {
testImplementation project(':micrometer-test')
}

// new module in 1.9. This can be removed in later branches.
if ("$project.version".startsWith("1.9.")) {
japicmp.enabled = false
downloadBaseline.enabled = false
}
// new module in 1.9. This should be removed in later branches.
japicmp.enabled = false
downloadBaseline.enabled = false

0 comments on commit aa5be1e

Please sign in to comment.