Skip to content

Commit

Permalink
Exclude netty-codec-http from statsd module
Browse files Browse the repository at this point in the history
We do not use HTTP in the statsd module, but netty-codec-http is brought in as a transitive dependency from reactor-netty-core. Our usage of reactor-netty-core works without this dependency. To reduce the amount of false positive reports we have to deal with, and to reduce the produced JAR size, we can exclude this unneeded dependency.

Resolves gh-2929
  • Loading branch information
shakuzen committed Dec 22, 2021
1 parent 514b4b9 commit 92e1881
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 4 additions & 1 deletion implementations/micrometer-registry-statsd/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ dependencies {
api project(':micrometer-core')

implementation 'io.projectreactor:reactor-core'
implementation 'io.projectreactor.netty:reactor-netty-core'
implementation('io.projectreactor.netty:reactor-netty-core') {
// We do not use HTTP modules; exclude to avoid false positive CVE reports
exclude module: 'netty-codec-http'
}

testImplementation project(':micrometer-test')
testImplementation 'io.projectreactor:reactor-test'
Expand Down
1 change: 0 additions & 1 deletion implementations/micrometer-registry-statsd/gradle.lockfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 92e1881

Please sign in to comment.