Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix headers and resource attributes in oltp #330

Closed
wants to merge 1 commit into from
Closed

Fix headers and resource attributes in oltp #330

wants to merge 1 commit into from

Conversation

kkocel
Copy link
Contributor

@kkocel kkocel commented Sep 13, 2023

No description provided.

jonatan-ivanov
jonatan-ivanov approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@jonatan-ivanov jonatan-ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reference: OtlpProperties in Boot

@jonatan-ivanov
Copy link
Member

Thank you for fixing this!

@kkocel
Copy link
Contributor Author

kkocel commented Sep 14, 2023

@jonatan-ivanov I noticed that tests failed but I don't know why tbh.

@jonatan-ivanov
Copy link
Member

main was failing due to a fix in Micrometer tracing, I fixed it and mereged your PR in.
Thank you very much again!

jonatan-ivanov added a commit to micrometer-metrics/micrometer that referenced this pull request Jan 22, 2024
@jonatan-ivanov
Fix headers and resource attributes in oltp.adoc
b77b214 
See: micrometer-metrics/micrometer-docs#330

See gh-4611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkocel @jonatan-ivanov