fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) #1712

gbr1 · 2024-03-21T11:40:59Z

By importing time.h instead of sys/time.h you can build micro-ros for Arduino UNO R4.

It addresses issue: #1461

This PR was tested on following targets:

mbed (Arduino GIGA R1)
m4 (Arduino UNO R4 Minima)
stm32 (STMicroelectronics Nucleo F401RE)

added Arduino Giga (USB and WiFi)

gbr1 · 2024-03-27T14:10:00Z

I added also Arduino Giga (USB and WiFi).

It is practically the same of an Arduino Portenta H7, so it was quite easy

uno R4 WiFi

gbr1 · 2024-03-27T16:36:06Z

Latest PR adds WiFi for Arduino UNO R4.

examples/micro-ros_publisher_wifi/micro-ros_publisher_wifi.ino

led builtin check

gbr1 · 2024-07-10T10:14:12Z

Hi @pablogs9 , any update on this PR?

pablogs9 · 2024-07-10T10:37:01Z

Could you please add the new supported boards to supported boards community table, also is there a possibility of having some CI on this new boards?

pablogs9 · 2024-07-11T05:53:29Z

CI failing

.github/workflows/ci.yml

gbr1 · 2024-07-11T13:29:46Z

@pablogs9 it should work now, let me know

gbr1 · 2024-07-11T14:30:04Z

I don't understand how it works, I have modified only iron branch, should I change manually also rolling and humble?

pablogs9 · 2024-07-11T14:40:14Z

I don't understand how it works,

How what works?

gbr1 · 2024-07-11T14:41:26Z

I don't understand how it works,

How what works?

The CI

pablogs9 · 2024-07-11T14:43:01Z

Maybe because the fixed version of Arduino CLI: https://github.com/micro-ROS/micro_ros_arduino/blob/e27dbad513f4632966006298682d62846c208014/.github/workflows/ci.yml#L24C8-L24C110 ??

james-yoo · 2024-07-24T09:35:53Z

Any update?

gbr1 · 2024-07-24T09:37:24Z

@james-yoo I don't know why on my CI it works but fails on the one of microros :'(

gbr1 · 2024-08-02T10:24:25Z

Hi @pablogs9 , it seems that everything is correct now

gbr1 · 2024-11-14T11:41:03Z

@pablogs9 any update on this?

pablogs9 · 2024-11-14T11:49:25Z

Closing and reopening to trigger CI again

pablogs9 · 2024-11-14T11:54:23Z

@mergify backport rolling jazzy humble

mergify · 2024-11-14T11:54:48Z

backport rolling jazzy humble

✅ Backports have been created

#1863 fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (backport #1712) has been created for branch rolling but encountered conflicts
#1864 fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (backport #1712) has been created for branch jazzy but encountered conflicts
#1865 fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (backport #1712) has been created for branch humble

pablogs9 · 2024-11-14T13:16:00Z

Sorry for the delay folks, merging it now. Thanks for the contribution.

…4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (#1712) * fixes time.h import * added support for Arduino GIGA R1 over WiFi * examples with giga r1 * uint -> uint32_t, added uno r4 wifi * added uno r4 into the example * added uno r4 family into library properties * led builtin check * added boards into readme * updated ci * fix typo * updated cli version * force update index * reverted cli (cherry picked from commit e347a4a) # Conflicts: # .github/workflows/ci.yml # README.md # examples/micro-ros_publisher_wifi/micro-ros_publisher_wifi.ino # examples/micro-ros_publisher_wifi_at/micro-ros_publisher_wifi_at.ino # src/micro_ros_arduino.h # src/wifi_transport.cpp

…4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (#1712) * fixes time.h import * added support for Arduino GIGA R1 over WiFi * examples with giga r1 * uint -> uint32_t, added uno r4 wifi * added uno r4 into the example * added uno r4 family into library properties * led builtin check * added boards into readme * updated ci * fix typo * updated cli version * force update index * reverted cli (cherry picked from commit e347a4a)

…4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (#1712) (#1865) * fixes time.h import * added support for Arduino GIGA R1 over WiFi * examples with giga r1 * uint -> uint32_t, added uno r4 wifi * added uno r4 into the example * added uno r4 family into library properties * led builtin check * added boards into readme * updated ci * fix typo * updated cli version * force update index * reverted cli (cherry picked from commit e347a4a) Co-authored-by: Giovanni Bruno <[email protected]>

pablogs9 · 2024-11-14T13:45:53Z

@gbr1 can you take a look at #1864 and #1863 ?

gbr1 · 2024-11-14T15:15:16Z

It seems it wrongly detect arduino nano rp2040, but I am also trying to compile some firmware for other boards and it seems to be broken on rclc_timer_init_default declared in rclc/timer.h:63:1

gbr1 · 2024-11-14T15:21:24Z

@pablogs9 is it correct that the ci test the build for raspberry pi pico (mbed_rp2040:pico) as target for publisher with wifi in AT mode? The board hasn't got the wifi

Please check here: https://github.com/micro-ROS/micro_ros_arduino/pull/1712/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL86

gbr1 · 2024-11-14T16:52:40Z

@pablogs9 I can confirm, it seems that raspberry pi pico target was added on BOARD_WITH_ESP_ATby this https://github.com/micro-ROS/micro_ros_arduino/pull/1425/commits but in jazzy seems that arduino-cli lib install WiFiEspATis missing in ci.yml because also building that example is removed

Iron one: https://github.com/micro-ROS/micro_ros_arduino/blob/iron/.github/workflows/ci.yml#L62C1-L63C1
Official Jazzy one: https://github.com/micro-ROS/micro_ros_arduino/blob/jazzy/.github/workflows/ci.yml#L51

Let me know how to proceed

…4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (backport #1712) (#1864) * fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (#1712) * fixes time.h import * added support for Arduino GIGA R1 over WiFi * examples with giga r1 * uint -> uint32_t, added uno r4 wifi * added uno r4 into the example * added uno r4 family into library properties * led builtin check * added boards into readme * updated ci * fix typo * updated cli version * force update index * reverted cli (cherry picked from commit e347a4a) # Conflicts: # .github/workflows/ci.yml # README.md # examples/micro-ros_publisher_wifi/micro-ros_publisher_wifi.ino # examples/micro-ros_publisher_wifi_at/micro-ros_publisher_wifi_at.ino # src/micro_ros_arduino.h # src/wifi_transport.cpp * Fix rebase * Update ci.yml --------- Co-authored-by: Giovanni Bruno <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>

…4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (backport #1712) (#1863) * fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (#1712) * fixes time.h import * added support for Arduino GIGA R1 over WiFi * examples with giga r1 * uint -> uint32_t, added uno r4 wifi * added uno r4 into the example * added uno r4 family into library properties * led builtin check * added boards into readme * updated ci * fix typo * updated cli version * force update index * reverted cli (cherry picked from commit e347a4a) # Conflicts: # .github/workflows/ci.yml # README.md # examples/micro-ros_publisher_wifi/micro-ros_publisher_wifi.ino # examples/micro-ros_publisher_wifi_at/micro-ros_publisher_wifi_at.ino # src/micro_ros_arduino.h # src/wifi_transport.cpp * Fix rebase * Update ci.yml --------- Co-authored-by: Giovanni Bruno <[email protected]> Co-authored-by: Pablo Garrido <[email protected]>

pablogs9 · 2024-11-15T07:02:17Z

Got them merged, thanks a lot @gbr1

fixes time.h import

362acd4

gbr1 mentioned this pull request Mar 21, 2024

Support for Arduino Uno R4 #1461

Closed

gbr1 and others added 3 commits March 26, 2024 16:29

added support for Arduino GIGA R1 over WiFi

1c1e4f8

examples with giga r1

baf9e16

Merge pull request #1 from gbr1/iron-giga

40be44a

added Arduino Giga (USB and WiFi)

gbr1 changed the title ~~fixed time.h import~~ fixed time.h import, added Arduino Giga R1 (USB and WiFi) Mar 27, 2024

gbr1 and others added 4 commits March 27, 2024 17:14

uint -> uint32_t, added uno r4 wifi

95a5b88

added uno r4 into the example

00d0916

added uno r4 family into library properties

3aee142

Merge pull request #2 from gbr1/iron-giga

b87a23a

uno R4 WiFi

gbr1 changed the title ~~fixed time.h import, added Arduino Giga R1 (USB and WiFi)~~ fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) Mar 27, 2024

facchinm suggested changes Mar 27, 2024

View reviewed changes

examples/micro-ros_publisher_wifi/micro-ros_publisher_wifi.ino Outdated Show resolved Hide resolved

gbr1 and others added 3 commits March 27, 2024 17:53

led builtin check

fae478c

Merge pull request #3 from gbr1/iron-giga

0d2ca6f

led builtin check

Merge branch 'micro-ROS:iron' into iron

1686454

gbr1 and others added 3 commits July 10, 2024 17:10

added boards into readme

0899722

Merge branch 'micro-ROS:iron' into iron

67e2139

updated ci

abb2a9a

pablogs9 reviewed Jul 11, 2024

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

gbr1 and others added 2 commits July 11, 2024 11:21

fix typo

05dae2b

Merge branch 'micro-ROS:iron' into iron

b5b0e74

updated cli version

460cd0f

force update index

92d521e

reverted cli

fcef038

pablogs9 closed this Nov 14, 2024

pablogs9 reopened this Nov 14, 2024

pablogs9 approved these changes Nov 14, 2024

View reviewed changes

pablogs9 merged commit e347a4a into micro-ROS:iron Nov 14, 2024
3 checks passed

mergify bot mentioned this pull request Nov 14, 2024

fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) (backport #1712) #1863

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) #1712

fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) #1712

gbr1 commented Mar 21, 2024

gbr1 commented Mar 27, 2024

gbr1 commented Mar 27, 2024 •

edited

Loading

gbr1 commented Jul 10, 2024

pablogs9 commented Jul 10, 2024

pablogs9 commented Jul 11, 2024

gbr1 commented Jul 11, 2024

gbr1 commented Jul 11, 2024

pablogs9 commented Jul 11, 2024

gbr1 commented Jul 11, 2024

pablogs9 commented Jul 11, 2024

james-yoo commented Jul 24, 2024

gbr1 commented Jul 24, 2024

gbr1 commented Aug 2, 2024

gbr1 commented Nov 14, 2024

pablogs9 commented Nov 14, 2024

pablogs9 commented Nov 14, 2024

mergify bot commented Nov 14, 2024 •

edited

Loading

pablogs9 commented Nov 14, 2024

pablogs9 commented Nov 14, 2024

gbr1 commented Nov 14, 2024

gbr1 commented Nov 14, 2024

gbr1 commented Nov 14, 2024 •

edited

Loading

pablogs9 commented Nov 15, 2024

fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) #1712

fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) #1712

Conversation

gbr1 commented Mar 21, 2024

gbr1 commented Mar 27, 2024

gbr1 commented Mar 27, 2024 • edited Loading

gbr1 commented Jul 10, 2024

pablogs9 commented Jul 10, 2024

pablogs9 commented Jul 11, 2024

gbr1 commented Jul 11, 2024

gbr1 commented Jul 11, 2024

pablogs9 commented Jul 11, 2024

gbr1 commented Jul 11, 2024

pablogs9 commented Jul 11, 2024

james-yoo commented Jul 24, 2024

gbr1 commented Jul 24, 2024

gbr1 commented Aug 2, 2024

gbr1 commented Nov 14, 2024

pablogs9 commented Nov 14, 2024

pablogs9 commented Nov 14, 2024

mergify bot commented Nov 14, 2024 • edited Loading

✅ Backports have been created

pablogs9 commented Nov 14, 2024

pablogs9 commented Nov 14, 2024

gbr1 commented Nov 14, 2024

gbr1 commented Nov 14, 2024

gbr1 commented Nov 14, 2024 • edited Loading

pablogs9 commented Nov 15, 2024

gbr1 commented Mar 27, 2024 •

edited

Loading

mergify bot commented Nov 14, 2024 •

edited

Loading

gbr1 commented Nov 14, 2024 •

edited

Loading