Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiEspAT Support #1425

Merged
merged 13 commits into from
Jun 28, 2023
Merged

WiFiEspAT Support #1425

merged 13 commits into from
Jun 28, 2023

Conversation

maehara-keisuke
Copy link
Contributor

What I changed

  • Enable to compile micro-ros_publisher_wifi example in the following cases.
    • WiFiEspAT library is installed.
    • "USE_WIFI_ESP_AT" macro is defined at head of sketch.
  • Update CI for build example test.
  • Add section to describe about WiFiEspAT in README.md

What I tested

  • Run CI successfully in my forked repository.
  • Build micro-ros_publisher_wifi example for boards below and Run successfully.

Raspberry Pi Pico

raspberrypi_pico.mp4

Seeed Studio XIAO SAMD21

seeed_studio_xiao_samd21.mp4

Seeed Studio XIAO RP2040

seeed_studio_xiao_rp2040.mp4

pablogs9
pablogs9 reviewed Jun 19, 2023
View reviewed changes
@pablogs9
Copy link
Member

BTW, thanks a lot for this great work!

@maehara-keisuke
Copy link
Contributor Author

BTW, thanks a lot for this great work!

@pablogs9

Thank you for your reviewing. I'll plan to modify.

@maehara-keisuke
Copy link
Contributor Author

@pablogs9

I confirmed to work properly with each board.
Please re-review.

@pablogs9 pablogs9 requested a review from Acuadros95 June 26, 2023 05:27
Acuadros95
Acuadros95 suggested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@Acuadros95 Acuadros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, the rest LGTM

@maehara-keisuke @Acuadros95
Remove unnecessary build test.
f962cfb 
Co-authored-by: Antonio Cuadros <[email protected]>
@maehara-keisuke
Copy link
Contributor Author

@Acuadros95

Minor comments, the rest LGTM

Thanks for your suggestion. I reflected it.
Please re-review.

@Acuadros95
Copy link
Contributor

@mergify backport rolling iron

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023 •
edited
Loading

backport rolling iron

✅ Backports have been created

@Acuadros95 Acuadros95 merged commit f78b91c into micro-ROS:humble Jun 28, 2023
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
@maehara-keisuke @mergify
WiFiEspAT Support (#1425)
062e6e5 
* Extend set_microros_wifi_transport().

Signed-off-by: maehara-keisuke <[email protected]>

* Enable each function if BOARD_WITH_ESP_AT is defined.

Signed-off-by: maehara-keisuke <[email protected]>

* Enable to compile publisher_wifi example if USE_WIFI_ESP_AT is defined.

Signed-off-by: maehara-keisuke <[email protected]>

* Follow CI.

Signed-off-by: maehara-keisuke <[email protected]>

* Markdown table formattings.

Signed-off-by: maehara-keisuke <[email protected]>

* Add section for ESP-AT module.

Signed-off-by: maehara-keisuke <[email protected]>

* Revert micro-ros_publisher_wifi.

Signed-off-by: maehara-keisuke <[email protected]>

* Minor: fix typo.

Signed-off-by: maehara-keisuke <[email protected]>

* Add new example for ESP-AT.

Signed-off-by: maehara-keisuke <[email protected]>

* Follow CI.

Signed-off-by: maehara-keisuke <[email protected]>

* Simplify description about ESP-AT supported boards.

Signed-off-by: maehara-keisuke <[email protected]>

* Remove unnecessary build test.

Co-authored-by: Antonio Cuadros <[email protected]>

---------

Signed-off-by: maehara-keisuke <[email protected]>
Co-authored-by: Antonio Cuadros <[email protected]>
(cherry picked from commit f78b91c)
@mergify mergify bot mentioned this pull request Jun 28, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
@maehara-keisuke @mergify
WiFiEspAT Support (#1425)
86bd2d1 
* Extend set_microros_wifi_transport().

Signed-off-by: maehara-keisuke <[email protected]>

* Enable each function if BOARD_WITH_ESP_AT is defined.

Signed-off-by: maehara-keisuke <[email protected]>

* Enable to compile publisher_wifi example if USE_WIFI_ESP_AT is defined.

Signed-off-by: maehara-keisuke <[email protected]>

* Follow CI.

Signed-off-by: maehara-keisuke <[email protected]>

* Markdown table formattings.

Signed-off-by: maehara-keisuke <[email protected]>

* Add section for ESP-AT module.

Signed-off-by: maehara-keisuke <[email protected]>

* Revert micro-ros_publisher_wifi.

Signed-off-by: maehara-keisuke <[email protected]>

* Minor: fix typo.

Signed-off-by: maehara-keisuke <[email protected]>

* Add new example for ESP-AT.

Signed-off-by: maehara-keisuke <[email protected]>

* Follow CI.

Signed-off-by: maehara-keisuke <[email protected]>

* Simplify description about ESP-AT supported boards.

Signed-off-by: maehara-keisuke <[email protected]>

* Remove unnecessary build test.

Co-authored-by: Antonio Cuadros <[email protected]>

---------

Signed-off-by: maehara-keisuke <[email protected]>
Co-authored-by: Antonio Cuadros <[email protected]>
(cherry picked from commit f78b91c)
Acuadros95 pushed a commit that referenced this pull request Jun 28, 2023
@mergify @maehara-keisuke
WiFiEspAT Support (#1425) (#1443)
c14c4e3 
* Extend set_microros_wifi_transport().

Signed-off-by: maehara-keisuke <[email protected]>

* Enable each function if BOARD_WITH_ESP_AT is defined.

Signed-off-by: maehara-keisuke <[email protected]>

* Enable to compile publisher_wifi example if USE_WIFI_ESP_AT is defined.

Signed-off-by: maehara-keisuke <[email protected]>

* Follow CI.

Signed-off-by: maehara-keisuke <[email protected]>

* Markdown table formattings.

Signed-off-by: maehara-keisuke <[email protected]>

* Add section for ESP-AT module.

Signed-off-by: maehara-keisuke <[email protected]>

* Revert micro-ros_publisher_wifi.

Signed-off-by: maehara-keisuke <[email protected]>

* Minor: fix typo.

Signed-off-by: maehara-keisuke <[email protected]>

* Add new example for ESP-AT.

Signed-off-by: maehara-keisuke <[email protected]>

* Follow CI.

Signed-off-by: maehara-keisuke <[email protected]>

* Simplify description about ESP-AT supported boards.

Signed-off-by: maehara-keisuke <[email protected]>

* Remove unnecessary build test.

Co-authored-by: Antonio Cuadros <[email protected]>

---------

Signed-off-by: maehara-keisuke <[email protected]>
Co-authored-by: Antonio Cuadros <[email protected]>
(cherry picked from commit f78b91c)

Co-authored-by: maehara-keisuke <[email protected]>
@maehara-keisuke maehara-keisuke deleted the feature/add-wifiespat-support branch June 29, 2023 11:52
@samuk samuk mentioned this pull request Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maehara-keisuke @pablogs9 @Acuadros95