Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regression in video rendering framerates on Nvidia #552

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

oomek
Copy link
Collaborator

@oomek oomek commented Mar 19, 2019

  • Replacing triple buffering with frame queue seems to do much better job in ensuring the videos are playing smoothly. The unusual low framerate of videos was manifesting in some edge cases after the commit that fixed high cpu usage on playing videos and when triple buffering was added.
  • Refactored nvapi profile management to better handle situations when the user manually created a profile for Attract Mode.

- Replacing triple buffering with frame queue seems to do much better job in ensuring the videos are playing smoothly. The unusual low framerate of videos was manifesting in some edge cases after the commit that fixed high cpu usage on playing videos and when triple buffering was added.
- Refactored nvapi profile management to better handle situations when the user manually created a profile for Attract Mode.
@oomek oomek self-assigned this Mar 19, 2019
@oomek oomek changed the title Fixed reggression in video rendering framerates on Nvidia Fixed regression in video rendering framerates on Nvidia Mar 19, 2019
@mickelson mickelson merged commit 2060fd9 into mickelson:master Mar 23, 2019
@oomek oomek deleted the fix-nvidia-low-videos-fps branch April 17, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants