Improved decoding quality of videos with non 1:1 pixel aspect ratio #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many video snaps have non square pixel aspect ratio ( mostly MAME snaps ). This commit moves applying pixel aspect ratio from FeMedia ( on texture creation ) to FeImage ( sprite transform ).
mickelson
reviewed
Mar 15, 2019
src/fe_image.cpp
Outdated
| float FeTextureContainer::get_movie_aspect_ratio() const | ||
| { | ||
| if ( m_movie ) | ||
| m_movie->get_aspect_ratio(); |
There was a problem hiding this comment.
I think you want a return here so it is "return m_movie->get_ar()"
Otherwise I think this PR looks good, thanks
There was a problem hiding this comment.
Surprisingly it worked. I think the compiler assumed I want a return and did it for me :) Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many video snaps have non square pixel aspect ratio ( mostly MAME snaps ). This commit moves applying pixel aspect ratio from FeMedia ( on texture creation ) to FeImage ( sprite transform ).