Feature: mipmaps parameter for fe.Image class #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with mickelson's master
Overrides previus commit. Wrong file upladed
Overrides previous commit. Wrong file uploaded.
It's astonishing how many mistakes one can do by adding just one line of code. I blame fibrofog.
Gets/sets the automatic generation of mipmaps for the image/artwork/video. Setting mipmaps to true greatly improves the quality of scaled down images.
|
Andrew, would you be able to pull my commits and up the AM version when I finish my 3 features I’m working on? These features are: Mipmaps, font spacing and blending modes. |
|
sure thing. when i get some time i’m going to look at implementing “per display” layout parameters. Hopefully it’s not too difficult. That bundled with your changed seems like a good place for doing a new version
… On Mar 11, 2018, at 1:03 AM, Radek Dutkiewicz ***@***.***> wrote:
Andrew, would you be able to pull my commits and up an AM version when I finish my 3 features I’m working on? Those features are: Mipmaps, font spacing and blending modes.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I’m refining my other commit Blending modes which I haven’t pushed yet and I’ve decided to bind it per shader not per drawable and I’ve also changed the default blending mode for surfaces to Premultiplied to fix the black fringes when thre are transparent objects on it. Are you ok with that? |
|
What is the purpose of that per display parameter you mentioned. |
|
Will open a new pull request after rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .mipmaps parameter that gets/sets the automatic generation of mipmaps for the fe.Image objects.