Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dolphin config #417

Merged
merged 2 commits into from
Jun 23, 2018
Merged

Update Dolphin config #417

merged 2 commits into from
Jun 23, 2018

Conversation

flodef
Copy link
Contributor

@flodef flodef commented Jan 21, 2018

Add Wii iso file name (.ciso) in extensions parameter + system name (as dolphin also run game cube games)

Add Wii iso file name (.ciso) in extensions parameter + system name (as dolphin also run game cube games)
@Enverex
Copy link
Contributor

Enverex commented May 1, 2018

That won't work will it? The "system" variable is what Attract sends off to the "source" for identifying content so changing "Nintendo Wii" to "Nintendo Wii/Game Cube" will simply cause all scraping for that platform to fail, because the latter isn't a valid system on TGDB.

Remove "GameCube" Name as "NintendoWii" only is already checking for game in both Wii and GameCube
@flodef
Copy link
Contributor Author

flodef commented May 1, 2018

You're absolutely right. Thanks for this comment.
Actually, only "Nintendo Wii" is checking for both Wii and GameCube.
I corrected it.

@mickelson mickelson merged commit b549f37 into mickelson:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants