Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu version #416

Merged
merged 2 commits into from
Apr 29, 2018
Merged

Update Ubuntu version #416

merged 2 commits into from
Apr 29, 2018

Conversation

flodef
Copy link
Contributor

@flodef flodef commented Jan 21, 2018

Update Ubuntu version, adding missing package with fresh install, and beginner's instructions.

Update Ubuntu version, adding missing package with fresh install, and beginner's instructions.
Copy link

@niedzielski niedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flodef, AWESOME notes! I was able to build Attract easily with these. I'm not involved with the project at all but since I used your PR and found a typo, I thought I would mention how helpful they were. Here are the steps I did:

docker run -tiv /home/stephen/Desktop/attract:/attract ubuntu:18.04
apt install build-essential libsfml-dev libopenal-dev zlib1g-dev libfreetype6-dev libavformat-dev libavcodec-dev libswscale-dev libavutil-dev libswresample-dev freeglut3-dev libjpeg-dev libarchive-dev
make

Compile.md Outdated
- FreeType 2 [libfreetype6-dev]
- The following FFmpeg libraries (required for videos):
* avformat [libavformat-dev],
* avcodec [libavcoded-dev],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo: libavcodec-dev.

* swresample [libswresample-dev] or avresample [libavresample-dev].
- OpenGL and GLU (or OpenGLES for GLES version) [freeglut3-dev]
- JPEG library [libjpeg-dev]
- Make [make] and Package Config [pkg-config]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make is covered above:

These instructions assume that you have the GNU C/C++ compilers and basic
build utilities (make, pkg-config, ar) on your system. This means the build utilities (make, pkg-config, ar) on your system. This means the
"build-essential" and "pkg-config" packages on Debian or Ubuntu-based "build-essential" and "pkg-config" packages on Debian or Ubuntu-based
distributions. Other distributions should have similar packages available. distributions.

I did have to install pkg-config explicitly though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your comments.
When I tried to install AttractMode for the first time, I didn't quite understand the comment on make, pkg-config, ar. It was all new to me. I spend some time searching for librairies that I needed.
That's why I added [make] and [pkg-config], just in case ;-)

Correct some tiny typos. Thanks @niedzielski
@mickelson mickelson merged commit 5d52b77 into mickelson:master Apr 29, 2018
@Enverex
Copy link
Contributor

Enverex commented Apr 30, 2018

This reads a bit weird as Ubuntu is Linux.

May have been worth having a specific sub-section for Ubuntu (if you wanted to be that specific) because the Linux instructions are now wrong. They're worded as though they apply to Linux in general but only actually apply to Ubuntu (and maybe Debian).

I personally would have rejected this pull because it just doesn't make sense or fit in general.

@mickelson
Copy link
Owner

Good point Enverex, I wasn't paying careful enough attention to what was being changed when I accepted this and forgot that the wiki has system specific compile directions. I will look at correcting

@flodef
Copy link
Contributor Author

flodef commented May 28, 2018

Mickelson, I don't know about the wiki and maybe it causes some problems.

Enverex, the main idea is, as a newbie who tries to compile for the first time, it should be easily doable without searching around for hours. Ubuntu is not Linux, it sits on top of it (for example, Android is not Linux too). And maybe a sub section would be better. I don't know about other Linux-based system (Fedora, Mint, Debian, ...) but when I wrote this, I guessed that for all systems, if the package was already there it was not so much a big deal. It seems that I was wrong.

Enverex, please feel free to add your own subsection with your own system. Thanks a lot for your comment.

@Enverex
Copy link
Contributor

Enverex commented May 28, 2018

Enverex, the main idea is, as a newbie who tries to compile for the first time, it should be easily doable without searching around for hours.

That's fine, but they're going to be even more confused when you're telling them to run commands that simply won't work on their distro (i.e. anything other than Ubuntu and maybe Debian).

Ubuntu is not Linux, it sits on top of it

This is semantics. When anyone says "Linux" you know they're referring to a Linux kernel based distribution, at least on desktops.

The notes themselves are helpful, but my concern was that I feel they've been added in the wrong place for the reasons originally stated.

@flodef
Copy link
Contributor Author

flodef commented Jun 22, 2018

I wrote a new version of attract/Compile.md in patch-5.
You were right guys and I think this last version is better.
Thanks a lot for your help and all your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants