Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow downward trackball movement responsiveness #322

Merged
merged 1 commit into from
Mar 4, 2017

Conversation

djrobx
Copy link
Contributor

@djrobx djrobx commented Mar 4, 2017

If you move the mouse downward very slowly, the wheel won't move. Turning on the mouse cursor, you can see this is because the mouse pointer position will reset to center at the moment that the mouse pointer leaves the bounding box. So you can keep scrolling slowly but indefinitely, and it will reset to the center position without ever passing the hit downward or right hit test that moves the wheel.

The upward and left movements do not have this issue.

By changing these checks to be >= instead of >, it hits properly and moves symmetrically with the up or left scrolling. The end result feels much more precise.

@mickelson mickelson merged commit 53ad50e into mickelson:master Mar 4, 2017
@mickelson
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants