obj/fe_blend.o fails to compile

[fanfani]

hello there,

i am having issues compiling attractmode from latest git (relevant compiler output below)
i'm running debian jessie, and did not have any issues compiling from source until recently.

Compiling obj/fe_blend.o...
src/fe_blend.cpp: In static member function ‘static sf::BlendMode FeBlend::get_blend_mode(int)’:
src/fe_blend.cpp:35:76: error: expression list treated as compound expression in functional cast [-fpermissive]
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcColor);
                                                                            ^
src/fe_blend.cpp:35:24: error: expected primary-expression before ‘(’ token
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcColor);
                        ^
src/fe_blend.cpp:35:29: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcColor);
                             ^
src/fe_blend.cpp:35:49: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcColor);
                                                 ^
src/fe_blend.cpp:37:81: error: expression list treated as compound expression in functional cast [-fpermissive]
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::OneMinusSrcAlpha);
                                                                                 ^
src/fe_blend.cpp:37:24: error: expected primary-expression before ‘(’ token
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::OneMinusSrcAlpha);
                        ^
src/fe_blend.cpp:37:29: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::OneMinusSrcAlpha);
                             ^
src/fe_blend.cpp:37:54: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::OneMinusSrcAlpha);
                                                      ^
src/fe_blend.cpp:39:73: error: expression list treated as compound expression in functional cast [-fpermissive]
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::SrcColor);
                                                                         ^
src/fe_blend.cpp:39:24: error: expected primary-expression before ‘(’ token
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::SrcColor);
                        ^
src/fe_blend.cpp:39:29: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::SrcColor);
                             ^
src/fe_blend.cpp:39:54: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::DstColor, sf::BlendMode::SrcColor);
                                                      ^
src/fe_blend.cpp:41:76: error: expression list treated as compound expression in functional cast [-fpermissive]
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcAlpha);
                                                                            ^
src/fe_blend.cpp:41:24: error: expected primary-expression before ‘(’ token
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcAlpha);
                        ^
src/fe_blend.cpp:41:29: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcAlpha);
                             ^
src/fe_blend.cpp:41:49: error: ‘sf::BlendMode’ is not a class or namespace
    return sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcAlpha);
                                                 ^
Makefile:456: set di istruzioni per l'obiettivo "obj/fe_blend.o" non riuscito
make: *** [obj/fe_blend.o] Errore 1

ciao!

[oomek]

Have you tried compiling with full clean?

[fanfani]

do you mean did i run make clean before make? yes i did

[oomek]

Could you try my fork with the recent fixes and tell if the issue is also there ?
https://github.com/oomek/attract/tree/fixes

Also, are you compiling for linux or cross-compiling?

[fanfani]

just run:

$ git clone https://github.com/oomek/attract.git

$ cd attract

$ make

same result

(compiling for linux)

[oomek]

What SFML version do you have there?

[fanfani]

$ aptitude versions libsfml-dev
Package libsfml-dev:                        
i   2.1+dfsg2-1+b1    stable    500 

[oomek]

From what I see you have quite old sfml libs 2.1 Update to 2.4.0 or the latest 2.5.1 to get it compiling. SFML BlendMode was added from what I remember in 2.3.0
Is there any particular reason you got the dev package? I think those are the libraries for debugging.

[mickelson]

Attractmode is meant to work on any sfml 2.x version. I didn’t realize blendmode was only added with sfml 2.3 when this was merged. This is a bug in Attractmode that will get fixed when I am able to work on it again (in about 3 weeks)... thanks for reporting this

…

On Jun 1, 2018, at 2:22 PM, Radek Dutkiewicz ***@***.***> wrote: From what I see you have quite old sfml libs 2.1 Update to 2.4.0 or the latest 2.5.1 to get it compiling. SFML BlendMode was added from what I remember in 2.3.0 Is there any particular reason you got the dev package? I think those are the libraries for debugging sfml. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[oomek]

Actually to be precise it’s about constructing custom blend modes which I used for non standard blending. The standard blending modes were present in earlier sfml versions

[oomek]

What do you do in that kind of situations?

[oomek]

Andrew, would you please explain to me what is the reason of keeping the compatibility with the old SFML libraries?

[mickelson]

Well the main reason is that the compile instructions in compile.md state that any 2.x version of SFML is what is needed to compile. Beyond that, I want it to be as backwards compatible as possible (within reason) because there are many reasons why people may not be able to use the most recent sfml (Debian and some other linux distros don’t get released that often, etc.).

…

On Jun 3, 2018, at 10:11 AM, Radek Dutkiewicz ***@***.***> wrote: Andrew, would you please explain to me what is the reason of keeping the compatibility with the old SFML libraries? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[mickelson]

Hi there, I'm unable to reproduce this here but some changes have been made that might fix this. Could you try compiling again with the latest code from master and let me know if it fixes this? thanks

[fanfani]

hi, I tried to compile again on the same system (debian jessie) and after issuing git pull.

it fails in the very same way (except for slightly different line numbers):

Compiling obj/fe_blend.o...
src/fe_blend.cpp: In static member function ‘static sf::BlendMode FeBlend::get_blend_mode(int)’:
src/fe_blend.cpp:35:78: error: expression list treated as compound expression in functional cast [-fpermissive]
    retval = sf::BlendMode(sf::BlendMode::One, sf::BlendMode::OneMinusSrcColor);
[...]

[oomek]

Calling BlendMode constructor will fail on older SFML versions. Some additional checks for the SFML versions will be required or just simple try catch block.

[mickelson]

ok i think I've got it now, could you try updating and compiling again??

[fanfani]

it works! thank you :-)