Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: mkdir obj should be run in priority #207

Closed
akien-mga opened this issue Apr 3, 2016 · 1 comment
Closed

Makefile: mkdir obj should be run in priority #207

akien-mga opened this issue Apr 3, 2016 · 1 comment

Comments

@akien-mga
Copy link

I've had an issue when trying to build attract for the first time in a git clone, using make -j3.
It spawned three parallel instructions for mkdir obj, mkdir obj/squirrel and mkdir obj/sqstdlib, and someone the last two were faster and failed because obj hadn't been created yet.

I haven't managed to reproduce it reliably, but to be on the safe side, you should probably either:

  • ensure that mkdir obj is run first, and that the rest are only processed once it has succeeded, even when using parallel make
  • or simpler, use mkdir -p to have the mkdir -p obj/squirrel succeed even if obj is missing.
mickelson added a commit that referenced this issue Apr 9, 2016
@mickelson
Copy link
Owner

Ok, I've changed the makefile to now use mkdir -p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants