Modernize code for DefaultBindingResolver

Leverage generics and instanceof pattern for safer typing
mickaelistria · Jan 13, 2024 · f316be6 · f316be6
1 parent f700559
commit f316be6
Show file tree

Hide file tree

Showing 2 changed files with 206 additions and 328 deletions.
diff --git a/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/AnnotationBinding.java b/org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/AnnotationBinding.java
@@ -110,7 +110,7 @@ public IMemberValuePairBinding[] getAllMemberValuePairs() {
 	@Override
 	public IJavaElement getJavaElement() {
 		if (!(this.bindingResolver instanceof DefaultBindingResolver)) return null;
-		ASTNode node = (ASTNode) ((DefaultBindingResolver) this.bindingResolver).bindingsToAstNodes.get(this);
+		ASTNode node = ((DefaultBindingResolver) this.bindingResolver).bindingsToAstNodes.get(this);
 		if (!(node instanceof Annotation)) return null;
 		ASTNode parent = node.getParent();
 		IJavaElement parentElement = null;
@@ -175,7 +175,7 @@ public String getKey() {
 	private String getRecipientKey() {
 		if (!(this.bindingResolver instanceof DefaultBindingResolver)) return ""; //$NON-NLS-1$
 		DefaultBindingResolver resolver = (DefaultBindingResolver) this.bindingResolver;
-		ASTNode node = (ASTNode) resolver.bindingsToAstNodes.get(this);
+		ASTNode node = resolver.bindingsToAstNodes.get(this);
 		if (node == null) {
 			// Can happen if annotation bindings have been resolved before having parsed the declaration
 			return ""; //$NON-NLS-1$