Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Windows compatibility of CI #60

Merged
merged 1 commit into from
Jul 30, 2023
Merged

ci: Windows compatibility of CI #60

merged 1 commit into from
Jul 30, 2023

Conversation

michalc
Copy link
Owner

@michalc michalc commented Jul 30, 2023

To run tests on Windows:

  • Setting environment variables for the entire job was the only way I could work out how to set for processes running in the job

  • MinIO seems to close after the step, even if run in the backround. So, running it in the same step as the tests is required

  • NamedTemporaryFile opens the file, which on Windows forbids it from being opened by SQLite. So, avoiding this.

To run tests on windows:

- Setting environment variables for the entire job was the only way I could
  work out how to set for processes running in the job

- MinIO seems to close after the step, even if run in the backround. So,
  running it in the same step as the tests is required

- NamedTemporaryFile opens the file, which on Windows forbids it from being
  opened by SQLite. So, avoiding this.
@michalc michalc force-pushed the ci/windows-compatibility branch from 0201b22 to ad802fb Compare July 30, 2023 14:05
@michalc michalc changed the title ci: Windows compatibility ci: Windows compatibility of CI Jul 30, 2023
@michalc michalc merged commit 8a88357 into main Jul 30, 2023
@michalc michalc deleted the ci/windows-compatibility branch July 30, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant