Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

deb: Fix syntax for dependency with min and max version #64

Conversation

michaelweghorn
Copy link
Contributor

Versioned dependencies where both a minimum and maximum version
are present need to be specified as follows in Debian packages:

<dependency_type>: <packagename> (>= <min_version>), <packagename> (<= <max_version>)

Currently, using versioned dependencies with both a minimum and a maximum version lead to an error when trying to create a Debian package.

Example list file:

%product Kung Foo Firewall
%copyright 1999-2005 by Foo Industries, All Rights Reserved.
%vendor Foo Industries
%license COPYING
%readme README
%description Kung Foo firewall software for your firewall.
%version 1.2.3p4 1020304
%requires foobar 1.0 2.0

f 755 root root /tmp/dummy dummy

Resulting error message when trying to create a Debian package:

$ fakeroot epm -f deb spec
Packaging failed!

This pull request fixes this by introducing the correct syntax when writing the directive to the Debian control file.

Versioned dependencies where both a minimum and maximum version
are present need to be specified as follows in Debian packages:

    <packagename> (>= <min_version>), <packagename> (<= <max_version>)

(This fix is basically a forward-port of the following fix
for an older EPM version used for packaging LibreOffice:
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=2b62198dfcfd3fe738382207235a68cdc9b40d30
)
@michaelweghorn michaelweghorn force-pushed the michaelweghorn/fixDebianDependencyMinMax branch from 2102a44 to 43574fe Compare February 6, 2018 14:46
@michaelrsweet michaelrsweet self-assigned this Feb 7, 2018
@michaelrsweet michaelrsweet added this to the Stable milestone Feb 7, 2018
@michaelrsweet michaelrsweet merged commit 89014c1 into michaelrsweet:master Nov 18, 2020
@michaelweghorn michaelweghorn deleted the michaelweghorn/fixDebianDependencyMinMax branch November 19, 2020 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants