Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UploadVhostDefinitions() #274

Merged

Conversation

lescactus
Copy link

Correspond to POST /api/definitions/vhost.

Basically similar to UploadDefinitions() but with specifying the vhost.

Correspond to POST /api/definitions/vhost
Copy link
Owner

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added test fails on CI and locally. See ./bin/ci/before_build.sh.

Here are some details:

• [FAILED] [0.005 seconds]
RabbitMQ HTTP API client POST /api/definitions/vhost [It] should create queues and exchanges as specified in the definitions for vhost rabbit/hole
gopath/src/github.com/michaelklishin/rabbit-hole/rabbithole_test.go:4229

  [FAILED] Expected
      <string>:
  to equal
      <string>: rabbit/hole
  In [It] at: /gopath/src/github.com/michaelklishin/rabbit-hole/rabbithole_test.go:4256 @ 06/11/23 00:31:52.43
------------------------------

Summarizing 1 Failure:
  [FAIL] RabbitMQ HTTP API client POST /api/definitions/vhost [It] should create queues and exchanges as specified in the definitions for vhost rabbit/hole
  gopath/src/github.com/michaelklishin/rabbit-hole/rabbithole_test.go:4256

@lescactus
Copy link
Author

@michaelklishin The tests should be fixed now

@lescactus lescactus requested a review from michaelklishin June 19, 2023 08:49
@michaelklishin michaelklishin merged commit 1667f35 into michaelklishin:main Jun 19, 2023
@michaelklishin michaelklishin added this to the 2.16.0 milestone Jan 4, 2024
@lescactus lescactus deleted the feat/uploadvhostdefinitions branch January 4, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants