Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Success #3

Closed
gary-hammer opened this issue Oct 24, 2020 · 3 comments
Closed

Logging Success #3

gary-hammer opened this issue Oct 24, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@gary-hammer
Copy link

I installed 1.0.4 and it indeed corrects the high CPU issue.
However, it introduces logging of success. This will result in very high syslog usage of course.
How can I toggle this off? I tried log_success = false in the driver stanza with no effect.

Just for your information, the next (4.2.0) version of WeeWX has some changes in the data and how it is processed. beaufort is handled differently now.

Oct 24 10:41:56 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live.mappers: RainMapping[['1']]: First daily rain value Oct 24 10:41:56 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:41:56 tester weewxd[11871]: weewx[11871] INFO weewx.wxxtypes: Type beaufort has been deprecated. Use unit beaufort instead. Oct 24 10:41:58 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:01 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:03 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:06 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:08 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:08 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting poll packet Oct 24 10:42:11 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:13 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:16 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:18 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet Oct 24 10:42:18 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting poll packet Oct 24 10:42:21 tester weewxd[11871]: weewx[11871] INFO user.weatherlink_live: Emitting push (broadcast) packet

@michael-slx michael-slx added the bug Something isn't working label Oct 24, 2020
michael-slx added a commit that referenced this issue Oct 25, 2020
Log messages when a packet is emitted did not respect 'log_success'
configuration option.

Fixes issue #3
michael-slx added a commit that referenced this issue Oct 26, 2020
Log messages when a packet is emitted did not respect 'log_success'
configuration option.

Fixes issue #3
@michael-slx
Copy link
Owner

The issue regarding the logging messages should be fixed in the next release.


Also thanks for the reminder on the beaufort change.

Since the driver doesn't do anything with the beaufort type, it seems that the warning message is caused by the configuration option beaufort = prefer_hardware in the [StdWXCalculate] section. The warning disappears when this line is removed.

I'll removed it from the testing config.

michael-slx added a commit that referenced this issue Oct 26, 2020
The 'beaufort' type is deprecated in WeeWX 4.2. As such the 'beaufort'
option in the '[StdWXCalculate]' section is also no longer needed and
produces a deprecation warning.

Fixes concern mentioned in issue #3
@gary-hammer
Copy link
Author

gary-hammer commented Oct 26, 2020

This was not fixed in 1.0.5
I have this in the stanza:

[WeatherLinkLive]
log_success = false

@michael-slx michael-slx reopened this Oct 27, 2020
@michael-slx
Copy link
Owner

michael-slx commented Oct 27, 2020

Ah, ok.

This driver doesn't support per-driver logging options, only the system-wide log_success as well as log_failure and debug options are supported.

I.e. at the top of the weewx.conf file:

# Set to 1 for extra debug info, otherwise comment it out or set to zero
debug = 0

# Whether to log successful operations
log_success = False

# Whether to log unsuccessful operations
log_failure = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants