Added an option "--play-nice" for playing nice with the server (closi… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an option for playing nice with the server. This allows the tester to easier judge, wether the gemini-server is overall working or not.
I had some trouble with the concurrent connection scenenario. My server accepted all connection and i got green on the test. However, internally (on my side) the concurrent connections did not correctly work. This could have been easier found if the scripts included a "play nice" option and if the connection is not disconnected right away, but rather the reply was checked too.
The functionallity is deactivated by default and can be activated by setting the commandline parameter --play-nice .
Tests that explicitly test trailing \r\n behavior were not changed.