feat: fix excessive renders #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahg
added a commit
that referenced
this pull request
Feb 4, 2025
* feat: add rough token instance * feat: switch token render to mouse up * feat: send token instances to the API * fix: add forgotten interface * feat: create token instance * feat: add token instance update API and unit tests * feat: manage token instances under scene and implement get * feat: token instance deletion * feat: add missing tests for token instance deletion * feat: send token instance to server * feat: unified scene interface, scene token loading * feat: fix excessive renders (#357) * looks like we can do better on the rendering loop * steps toward avoiding repaints by detecting the right overlay version * feat: separate things from background and overlay * chore: minimize differences * fix: getting ready for drawing tokens * feat: token items load bitmap (#358) * feat: tokens now display but only until something happens * Feat/token items drawable placement (#360) * feat: fix the token location when rendering existing token instances * feat: work towards drawables * feat: draw working for token * feat: scale working * fix: get rid of rendering glitch on token placement * feat: rotating tokens works (but no tokens with scene rotation) * feat: rotational placement with scene rotation * chore: cleanup * fix: correct placement glitches * Feat/token items table state (#361) * feat: refactor to add token instances to table state * chore: make launch a little more descriptive * feat: visible tokens for frontend * fix: work with angle token instance in unit tests * feat: create visible or invisible tokens (#362) * feat: create remote branch * feat: set visibility on instance token creation * fix: whoops * asdf * feat: conversion not done. * feat: start with hydrated token instance * chore: store asset and token in hydrated instance * fix: use asset in remote display component. * chore: cleanup dependencies * chore: cleanup * fix: visible no longer part of token (unit test) * chore: code review cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.