fix: error display for all scene creation failures

micahg · Nov 29, 2024 · 7370d54 · 7370d54
1 parent ba98868
commit 7370d54
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/api/src/utils/localstore.ts b/packages/api/src/utils/localstore.ts
@@ -34,7 +34,7 @@ function getContentTypeExtension(contentType: string): string | null {
 export function getValidExtension(file: Express.Multer.File) {
   const idx = VALID_CONTENT_TYPES.indexOf(file.mimetype);
   if (idx === -1)
-    throw new Error(`Invalid mime type: ${file.mimetype}`, { cause: 400 });
+    throw new Error(`Invalid mime type: ${file.mimetype}`, { cause: 406});
   return CONTENT_TYPE_EXTS[idx];
 }
 
@@ -93,7 +93,7 @@ export function updateAssetFromLink(
       const ext = getContentTypeExtension(headers["content-type"]);
       if (!ext)
         throw new Error(`Invalid mime type: ${headers["content-type"]}`, {
-          cause: 400,
+          cause: 406,
         });
 
       const fileName = `${layer}.${ext}`;
@@ -146,7 +146,7 @@ export async function updateAssetFromUpload(
 ): Promise<LayerUpdate> {
   const ext = getContentTypeExtension(req.file.mimetype);
   if (!ext)
-    throw new Error(`Invalid mime type: ${req.file.mimetype}`, { cause: 400 });
+    throw new Error(`Invalid mime type: ${req.file.mimetype}`, { cause: 406 });
   const src = req.file.path;
   const fileName = `${layer}.${ext}`;
   const dest = `${DEST_FOLDER}/${scene.user}/scene/${scene._id}/${fileName}`;

diff --git a/packages/mui/src/middleware/ContentMiddleware.ts b/packages/mui/src/middleware/ContentMiddleware.ts
@@ -359,8 +359,11 @@ export const ContentMiddleware: Middleware =
             };
             if (err.response.status === 413) {
               error.msg = "Asset too big";
-              next({ type: "content/error", payload: error });
             }
+            if (err.response.status === 406) {
+              error.msg = "Invalid asset format";
+            }
+            next({ type: "content/error", payload: error });
             if (err.scene) {
               // delete the failed scene and set the current scene to nothing
               store.dispatch({