-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual machine manager #69
Add virtual machine manager #69
Conversation
from synology_dsm.helpers import SynoFormatHelper | ||
|
||
|
||
class SynoVirtualMachineManager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this class should be moved to __init__.py
"""Updates Virtual Machine Guest data.""" | ||
raw_data = self._dsm.get(self.API_KEY, "list") | ||
if raw_data: | ||
self._data = raw_data["data"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should create an own class for the guest object (suggest SynoVmmGuest
) which holds all the data and exposes properties (compare with surveillance_station)
Hi @realtek2017 Overall please compare with the implementation of surveillance_station - it implements the generic class Btw I'm missing the reboot method 😉 |
Thanks @mib1185 for all your comments, I appreciate your feedback. My reason for adding this was driven from being able to use this eventually on the homeassistant integration :) I will make the changes as requested, had some issues with getting poetry working so I will try and fix that for the tests. Well spotted on the reboot method - that would be helpful :) |
was hoping, that this is the reason behind 🤞
If you are using VSCode and have Docker installed on your system, you can use the devcontainer in this project 😉 |
This will be implemented with #363 |
Functionality extended to support Virtual Machine Manager API.
New methods include: