Fix cameras not reading data as bytes #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
mib1185
reviewed
Jan 15, 2023
|
|
||
| class SynoBaseApi: | ||
| """Base api class.""" | ||
|
|
||
| def __init__(self, dsm): | ||
| def __init__(self, dsm: "SynologyDSM") -> None: |
There was a problem hiding this comment.
uhhh ... very nice 👍 with this i can continue with #183
There was a problem hiding this comment.
I added it because I was doing some right clicking and following the code, and it made it a lot easier
There was a problem hiding this comment.
It might be better to make it a relative import in the future, but probably fine either way for now
mib1185
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.