Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug logging #100

Merged
merged 1 commit into from
Feb 9, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/synology_dsm/synology_dsm.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,10 @@ def _request(
url = self._build_url(api)

# Request data
response = self._execute_request(request_method, url, params, **kwargs)
self._debuglog("API: " + api)
self._debuglog("Request Method: " + request_method)
response = self._execute_request(request_method, url, params, **kwargs)
self._debuglog("Successful returned data")
self._debuglog("API: " + api)
self._debuglog("RESPONSE: " + str(response))

# Handle data errors
Expand Down Expand Up @@ -314,8 +314,8 @@ def _execute_request(self, method: str, url: str, params: dict, **kwargs):
quote(params[param]), "********"
)
self._debuglog("Request url: " + response_url)
self._debuglog("Request status_code: " + str(response.status_code))
self._debuglog("Request headers: " + str(response.headers))
self._debuglog("Response status_code: " + str(response.status_code))
self._debuglog("Response headers: " + str(response.headers))

if response.status_code == 200:
# We got a DSM response
Expand Down