Support for directory-only negation #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating your library I found one case that is a mismatch with how
.gitignore
works. It relates to support of directory-only negation - useful thing when you want to discard some spool dir, but keep the directory structure in the version control. The feature is used by Kedro framework in their proejct template:and makes it easy to store the structure of
data/
subdirs in git:This PR fixes the directory-only-negation support, together with a small test. You can also verify the behaviour with pure git:
If you're OK with my modifications, I would be glad if you can release it as a new version of pypi, so I can integrate non-fork version in my project. Thanks :-)