Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid skipping ranges when looping through queues #720

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Avoid skipping ranges when looping through queues #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ def entries(conn, queue, &block) # rubocop:disable Metrics/MethodLength

loop do
range_start = (page * page_size) - deleted_size

range_end = range_start + page_size - 1
entries = conn.lrange(queue_key, range_start, range_end)
page += 1
Expand All @@ -238,6 +239,9 @@ def entries(conn, queue, &block) # rubocop:disable Metrics/MethodLength
entries.each(&block)

deleted_size = initial_size - conn.llen(queue_key)

# The queue is growing, not shrinking, just keep looping
deleted_size = 0 if deleted_size.negative?
end
end

Expand Down