Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numerous small issues with locking #616

Merged
merged 6 commits into from
Jun 29, 2021
Merged

Conversation

mhenrixon
Copy link
Owner

@mhenrixon mhenrixon commented Jun 29, 2021

Extracts logic for each lock class into the class itself. Duplicate as much as possible to be able to better understand what is going wrong and fix + add test coverage for these issues.

There were a few issues fixed:

  1. Cleanup wasn't always working in certain cases
  2. Re-locking UntilAndWhileExecuting was broken because the original job hash was manipulated
  3. The RUN_SUFFIX might have been appended more than once
  4. In scenarios where the queue and primed tokens where "1" processing stopped
  5. config.wait_for_lock? had incorrect logic and has now been fixed
  6. Adds an UPGRADING.md document to be able to better approach such massive changes as here

@mhenrixon mhenrixon force-pushed the feature/test-coverage branch from 9fd9c1a to c3f493a Compare June 29, 2021 14:15
@mhenrixon mhenrixon force-pushed the feature/test-coverage branch from 84abb58 to f0e88a4 Compare June 29, 2021 14:42
@mhenrixon mhenrixon merged commit 87a6120 into master Jun 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/test-coverage branch June 29, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant