Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build keys on lua scripts #348

Merged
merged 2 commits into from
Nov 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/sidekiq_unique_jobs/constants.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ module SidekiqUniqueJobs
ON_CONFLICT_KEY ||= 'on_conflict'
UNIQUE_ON_ALL_QUEUES_KEY ||= 'unique_on_all_queues' # TODO: Remove in v6.1
UNIQUE_PREFIX_KEY ||= 'unique_prefix'
RETRY_SET ||= 'retry'
SCHEDULE_SET ||= 'schedule'
end
6 changes: 5 additions & 1 deletion lib/sidekiq_unique_jobs/on_conflict/replace.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ def call(&block)

# Delete the job from either schedule, retry or the queue
def delete_job_by_digest
Scripts.call(:delete_job_by_digest, nil, keys: [queue, unique_digest])
Scripts.call(
:delete_job_by_digest,
nil,
keys: ["#{QUEUE_KEY}:#{queue}", SCHEDULE_SET, RETRY_SET], argv: [unique_digest]
)
end

# Delete the keys belonging to the job
Expand Down
10 changes: 6 additions & 4 deletions redis/delete_job_by_digest.lua
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
local queue = "queue:" .. KEYS[1]
local unique_digest = KEYS[2]
local queue = KEYS[1]
local schedule_set = KEYS[2]
local retry_set = KEYS[3]
local unique_digest = ARGV[1]

local function delete_from_sorted_set(name, digest)
local per = 50
Expand Down Expand Up @@ -49,10 +51,10 @@ if result then
return result
end

result = delete_from_sorted_set('schedule', unique_digest)
result = delete_from_sorted_set(schedule_set, unique_digest)
if result then
return result
end

result = delete_from_sorted_set('retry', unique_digest)
result = delete_from_sorted_set(retry_set, unique_digest)
return result
2 changes: 1 addition & 1 deletion spec/examples/my_unique_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
described_class.perform_in(3600, 1, 2)
expect(1).to be_enqueued_in('customqueue')
expect(1).to be_enqueued_in('schedule')
expect(zcard('schedule')).to eq(1)
expect(schedule_count).to eq(1)
expect(1).to be_scheduled_at(Time.now.to_f + 2 * 3600)
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
jid = NotifyWorker.perform_in(1, 183, 'xxxx')
expect(jid).not_to eq(nil)

expect(zcard('schedule')).to eq(1)
expect(schedule_count).to eq(1)

expected = %w[
uniquejobs:6e47d668ad22db2a3ba0afd331514ce2:EXISTS
Expand All @@ -23,7 +23,7 @@
expect(SimpleWorker.perform_in(60, 1)).to eq(nil)
expect(SimpleWorker.perform_in(60, 1)).to eq(nil)
expect(SimpleWorker.perform_in(60, 1)).to eq(nil)
expect(zcard('schedule')).to eq(0)
expect(schedule_count).to eq(0)
expect(SpawnSimpleWorker.perform_async(1)).not_to eq(nil)

expect(queue_count('default')).to eq(1)
Expand Down