Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename command line binary #287

Merged
merged 6 commits into from
Jun 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 0 additions & 109 deletions .reek

This file was deleted.

110 changes: 110 additions & 0 deletions .reek.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
---
exclude_paths:
- rails_example
- redis
- spec
- tmp
- gemfiles
- examples
detectors:
DuplicateMethodCall:
exclude:
- Sidekiq#self.use_options
IrresponsibleModule:
exclude:
- Sidekiq::Simulator
- SidekiqUniqueJobs::Cli
- SidekiqUniqueJobs::Client::Middleware
- SidekiqUniqueJobs
- Array
- Hash
- SidekiqUniqueJobs::JidMissing
- SidekiqUniqueJobs::LockTimeout
- SidekiqUniqueJobs::MaxLockTimeMissing
- SidekiqUniqueJobs::RunLockFailed
- SidekiqUniqueJobs::ScriptError
- SidekiqUniqueJobs::UnexpectedValue
- SidekiqUniqueJobs::UniqueKeyMissing
- SidekiqUniqueJobs::UnknownLock
- SidekiqUniqueJobs::Lock::BaseLock
- SidekiqUniqueJobs::Lock::UntilAndWhileExecuting
- SidekiqUniqueJobs::Lock::UntilExecuted
- SidekiqUniqueJobs::Lock::UntilExecuting
- SidekiqUniqueJobs::Lock::UntilExpired
- SidekiqUniqueJobs::Lock::WhileExecuting
- SidekiqUniqueJobs::Lock::WhileExecutingReject
- SidekiqUniqueJobs::Lock::WhileExecutingRequeue
- SidekiqUniqueJobs::Locksmith
- SidekiqUniqueJobs::Middleware
- SidekiqUniqueJobs::Normalizer
- SidekiqUniqueJobs::Scripts
- SidekiqUniqueJobs::Server::Middleware
- Sidekiq::Job
- Sidekiq::Job::UniqueExtension
- Sidekiq::JobSet
- Sidekiq::JobSet::UniqueExtension
- Sidekiq::Queue
- Sidekiq::Queue::UniqueExtension
- Sidekiq::ScheduledSet
- Sidekiq::ScheduledSet::UniqueExtension
- Sidekiq::SortedEntry
- Sidekiq::SortedEntry::UniqueExtension
- Sidekiq
- Sidekiq::Worker
- Sidekiq::Worker::ClassMethods
- Sidekiq::Worker::Overrides
- Sidekiq::Worker::Overrides::Testing
- SidekiqUniqueJobs::Timeout::Calculator
- SidekiqUniqueJobs::Timeout
- SidekiqUniqueJobs::Unlockable
- SidekiqUniqueJobs::Util
TooManyStatements:
exclude:
- initialize
- Hash#slice
- SidekiqUniqueJobs::Locksmith#create_lock
- SidekiqUniqueJobs::Locksmith#expire_when_necessary
- SidekiqUniqueJobs::Middleware#configure_server_middleware
- SidekiqUniqueJobs::Server::Middleware#call
- SidekiqUniqueJobs::UniqueArgs#filtered_args
- SidekiqUniqueJobs::Util#del
UncommunicativeVariableName:
exclude:
- Hash#slice
BooleanParameter:
exclude:
- SidekiqUniqueJobs::Cli#self.banner
UtilityFunction:
enabled: false
TooManyConstants:
exclude:
- SidekiqUniqueJobs
ManualDispatch:
enabled: true
exclude:
- Hash#slice
- Hash#slice!
- SidekiqUniqueJobs::Lock::WhileExecutingReject#deadset_kill?
- SidekiqUniqueJobs::SidekiqWorkerMethods#worker_method_defined?
MissingSafeMethod:
exclude:
- Array
NilCheck:
enabled: false
FeatureEnvy:
exclude:
- SidekiqUniqueJobs::Lock::WhileExecutingReject#push_to_deadset
- SidekiqUniqueJobs::Logging#debug_item
- SidekiqUniqueJobs::Util#batch_delete
NestedIterators:
exclude:
- SidekiqUniqueJobs::Locksmith#create_lock
- SidekiqUniqueJobs::Middleware#configure_client_middleware
- SidekiqUniqueJobs::Middleware#configure_server_middleware
- SidekiqUniqueJobs::Util#batch_delete
TooManyInstanceVariables:
exclude:
- SidekiqUniqueJobs::Locksmith
TooManyMethods:
exclude:
- SidekiqUniqueJobs::Locksmith
12 changes: 8 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,25 @@ before_install:
- sudo apt-get update -qy
- sudo apt-get install redis-server
- sudo service redis-server start
before_script:
- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
- chmod +x ./cc-test-reporter
before_script:
- ./cc-test-reporter before-build
script:
- if [[ "${COV}" = "true" ]]; then bundle exec rubocop -P; fi;
- bundle exec rspec spec
- bundle exec rspec
after_script:
- if [[ "${COV}" = "true" ]]; then ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT; fi;

rvm:
- 2.5.1
- 2.4.2
- 2.3.2
- jruby-9.1.15.0
- jruby-9.1.17.0
- jruby-9.2.0.0
matrix:
allow_failures:
- rvm: jruby-9.1.17.0
- rvm: jruby-9.2.0.0
fast_finish: true
include:
- rvm: 2.5.1
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ There are two ways to display and remove keys regarding uniqueness. The console

### Console

Start the console with the following command `bundle exec jobs console`.
Start the console with the following command `bundle exec uniquejobs console`.

#### List Unique Keys

Expand All @@ -287,7 +287,7 @@ Start the console with the following command `bundle exec jobs console`.

### Command Line

`bundle exec jobs` displays help on how to use the unique jobs command line.
`bundle exec uniquejobs` displays help on how to use the unique jobs command line.

## Communication

Expand Down
2 changes: 1 addition & 1 deletion bin/jobs → bin/uniquejobs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
# frozen_string_literal: true

require 'bundler/setup'
require 'sidekiq-unique-jobs'
require 'sidekiq_unique_jobs'

SidekiqUniqueJobs::Cli.start(ARGV)
3 changes: 2 additions & 1 deletion sidekiq-unique-jobs.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Gem::Specification.new do |spec|
spec.license = 'MIT'

spec.bindir = 'bin'
spec.executables = %w[jobs]
spec.executables = %w[uniquejobs]

spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do
`git ls-files -z`.split("\x0").reject do |file|
file.match(%r{^(test|spec|features|gemfiles|pkg|rails_example|tmp)/})
Expand Down