-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidekiq Pro Sharded Web UI Error > 7.0.8 #605
Comments
Can't really help there since I don't have a sidekiq pro subscription. If someone would cover that for me I'd love to better support Sidekiq pro. Hard to debug without the code. |
Perhaps you could provide the stack trace of the entire thing (relevant unique jobs lines only). It seems like this is just a weird edge case that could be a problem regardless of Sidekiq Pro or not. |
Ah ok, I was confused about the PRO part. This has nothing to do with Sidekiq Pro. It is a situation for when the worker doesn't exist on where the code is running. The place it crashes needs to be handled better. I'll write a failing test for this later. |
@navied could you verify if the linked PR fixes the issue for you? I suspect you are gathering multiple sidekiq processes under a single |
@mhenrixon just gave it a try, looks all good on my side now! Thanks for the quick fix ! |
Describe the bug
When using Sidekiq Pro's Web UI Sharded mode, it breaks retrying, and deleting jobs due to this part of the code:
sidekiq-unique-jobs/lib/sidekiq_unique_jobs/sidekiq_unique_jobs.rb
Line 247 in 61af2aa
It tries to look for a job that does not exist on the instance that is running the web UI and instead ends up with a NameError.
Expected behavior
For the sidekiq web ui not to break
The text was updated successfully, but these errors were encountered: