Increase Code Coverage #80
Conversation
Gets 100% coverage on parsers.py
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
===========================================
+ Coverage 88.12% 99.16% +11.04%
===========================================
Files 6 6
Lines 362 361 -1
Branches 117 116 -1
===========================================
+ Hits 319 358 +39
+ Misses 21 1 -20
+ Partials 22 2 -20
Continue to review full report at Codecov.
|
| elif field in []: | ||
| return 'int vector' | ||
| # elif field in []: | ||
| # return 'int vector' | ||
| elif field in ['space origin']: | ||
| return 'double vector' | ||
| elif field in ['measurement frame']: |
There was a problem hiding this comment.
Isn't this the place where Isaiah and I corrected 'double matrix'? Not sure if you are working on a different branch.
There was a problem hiding this comment.
Yeah, this is the place. I just checked this PR and it's up to date. The measurement frame field type is 'double matrix' as corrected.
|
|
||
| # Set the line skip to be incorrect | ||
| header['line skip'] = -1 | ||
|
|
There was a problem hiding this comment.
I thought I added this one before, but thanks if I haven't.
There was a problem hiding this comment.
I think you tested the byte skip and line skip for all encoding except raw. But that's one benefit of code coverage is for, telling us when something isn't tested.
|
Don't see any obvious discrepancy. I would give it a green. |
|
@tashrifbillah Is this how long you meant by you needed time? That's nothing! I was expecting on the order of days to weeks! Thank you for the review. |
Went through and added tests to uncovered routes according to codecov. Went from 88% to 90%!
Small other changes made along the way.