Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed role bug where enumeration was wrong #13

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

okhleif-IL
Copy link
Collaborator

@okhleif-IL okhleif-IL commented Dec 4, 2024

Description

in the loop on line 906, the variable i was in the wrong block and therefore it would never equal to a value greater than 0. This caused role to never be concatenated to the prompt string later on.

Issues

https://github.com/opea-project/docs/blob/main/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

Verified fix with print statements

Copy link
Owner

@mhbuehler mhbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is some extra whitespace in line 906. The linter may not like that.

Signed-off-by: okhleif-IL <[email protected]>
@mhbuehler mhbuehler merged commit 1753473 into mmqna-audio-query Dec 4, 2024
@mhbuehler mhbuehler deleted the omar/role-debug branch December 4, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants