Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing EXE binary installers code paths and comments #2390

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Oct 11, 2024

I'm leaving this as draft for now given that:

  1. Just in case we want to produce EXE installers one more time before we close deprecate exe installers #1939, despite the 307 release not currently providing them
  2. This should be carefully reviewed to see if all obsolete/dead code has been cleaned-up and that everything works as it should from a Python (pip) install (sanity checks on Stop calling setup.py, use a build frontend #2396 look promising !)

Because of the removed conditions, hiding whitespace changes makes reviewing this a lot easier.

setup.py Outdated
Comment on lines 880 to 879
# If self.root has a value, it means we are being "installed" into some other
# directory than Python itself - in which case we must *not* run our installer.
# bdist_wininst used to trigger this by using a temp directory.
# Is this still a concern ?
if self.root:
print(
f"Not executing post install script when not installing in Python itself (self.root={self.root})"
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment says, is this still a concern? Or was this only done for the sake of an intermediate step in bdist_wininst ?

@Avasam Avasam force-pushed the Removing-EXE-binary-installers branch from d4a92be to a926c1f Compare October 13, 2024 04:45
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems sane to me, thanks.

@Avasam Avasam marked this pull request as ready for review October 13, 2024 18:05
@Avasam Avasam requested a review from mhammond October 18, 2024 18:44
@Avasam
Copy link
Collaborator Author

Avasam commented Dec 11, 2024

@mhammond If you feel confident enough in this PR, this can be approved/merged to unblock #2396 so that pywin32 stops using setup.py as a build script (legacy behaviour), and instead as a dynamic build configuration for setuptools.

@Avasam Avasam merged commit a8f0b0e into mhammond:main Dec 12, 2024
28 checks passed
@Avasam Avasam deleted the Removing-EXE-binary-installers branch December 12, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate exe installers
2 participants