[dot-imports] support allow list of packages #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @chavacava |
nunnatsa
force-pushed
the
fix-923
branch
3 times, most recently
from
21dc081 to
09b6755
Compare
denisvmedia
reviewed
Nov 26, 2023
denisvmedia
reviewed
Nov 26, 2023
| package pkg | ||
|
|
||
| import ( | ||
| . "context" // in allowedPackages (standard library => just the name without full path) |
There was a problem hiding this comment.
Can we please have a non-aliased and aliased imports to make sure they are not affected.
There was a problem hiding this comment.
Thanks for the review @denisvmedia. Fixed. PTAL.
denisvmedia
reviewed
Nov 26, 2023
Add the ability to allow list of packages to be dot imported.
Add a new don-imports configuration:
* `allowedPackages`: (string) comma-separated list of allowed dot import packages
Example:
```toml
[rule.dot-imports]
arguments = [{ allowedPackages = "github.com/onsi/ginkgo/v2,github.com/onsi/gomega" }]
```
|
Hi @nunnatsa thanks for the PR! (and sorry for the late response) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to allow list of packages to be dot imported.
Add a new don-imports configuration:
allowedPackages: (list of strings) comma-separated list of allowed dot import packagesExample:
Fixes #923