adds rule use-errors-new #1142
adds rule use-errors-new #1142
Conversation
| if len(funcCall.Args) > 1 { | ||
| return w // the use of fmt.Errorf is legit | ||
| } |
There was a problem hiding this comment.
Well, not exactly legit
We have crazy people out there
fmt.Errorf("%s, "whatever")
https://github.com/search?q=language%3Ago++%22fmt.Errorf%28%5C%22%25s%5C%22%2C+%5C%22%22&type=code
fmt.Errorf("%w", err)
https://github.com/search?q=language%3Ago++%22fmt.Errorf%28%5C%22%25w%5C%22%2C+%22&type=code
I created an issue on perfprint linter, as it's in their scope
I think you can merge like this, with current code.
My point can be addressed later
Originally posted by @ccoVeille in #1136 (comment)
There was a problem hiding this comment.
It was never my original goal to detect misuses like those because it implies too much complexity (less performance) to spot very veeeeery rare cases (written by people deserving to live with their own crazy code :) )
There was a problem hiding this comment.
I'm fine with this.
Maybe the comment could be updated to explain what you just wrote
Implementing a new rule
use-errors-newthat proposes replacingfmt.Errorfbyerrors.Newwhen possible.As indicated in this issue, beyond style considerations,
errors.Newsis ~4x faster thatfmt.Errorf(initial discussion on this PR can be retrieved at #1136)