helper: newInternalFailureError

mgechev · Dec 9, 2024 · ef674f6 · ef674f6
1 parent 0e4a8c4
commit ef674f6
Show file tree

Hide file tree

Showing 33 changed files with 38 additions and 32 deletions.
diff --git a/rule/add_constant.go b/rule/add_constant.go
@@ -46,7 +46,7 @@ func (r *AddConstantRule) Apply(file *lint.File, arguments lint.Arguments) []lin
 	var configureErr error
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure
@@ -69,6 +69,7 @@ func (r *AddConstantRule) Apply(file *lint.File, arguments lint.Arguments) []lin
 	return failures
 }
 
+
 // Name returns the rule name.
 func (*AddConstantRule) Name() string {
 	return "add-constant"

diff --git a/rule/argument_limit.go b/rule/argument_limit.go
@@ -38,7 +38,7 @@ func (r *ArgumentsLimitRule) Apply(file *lint.File, arguments lint.Arguments) []
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/banned_characters.go b/rule/banned_characters.go
@@ -40,7 +40,7 @@ func (r *BannedCharsRule) Apply(file *lint.File, arguments lint.Arguments) []lin
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/cognitive_complexity.go b/rule/cognitive_complexity.go
@@ -40,7 +40,7 @@ func (r *CognitiveComplexityRule) Apply(file *lint.File, arguments lint.Argument
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/comment_spacings.go b/rule/comment_spacings.go
@@ -34,7 +34,7 @@ func (r *CommentSpacingsRule) Apply(file *lint.File, arguments lint.Arguments) [
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/comments_density.go b/rule/comments_density.go
@@ -38,7 +38,7 @@ func (r *CommentsDensityRule) Apply(file *lint.File, arguments lint.Arguments) [
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	commentsLines := countDocLines(file.AST.Comments)

diff --git a/rule/context_as_argument.go b/rule/context_as_argument.go
@@ -22,7 +22,7 @@ func (r *ContextAsArgumentRule) Apply(file *lint.File, arguments lint.Arguments)
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/cyclomatic.go b/rule/cyclomatic.go
@@ -40,7 +40,7 @@ func (r *CyclomaticRule) Apply(file *lint.File, arguments lint.Arguments) []lint
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/defer.go b/rule/defer.go
@@ -30,7 +30,7 @@ func (r *DeferRule) Apply(file *lint.File, arguments lint.Arguments) []lint.Fail
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/dot_imports.go b/rule/dot_imports.go
@@ -21,7 +21,7 @@ func (r *DotImportsRule) Apply(file *lint.File, arguments lint.Arguments) []lint
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/enforce_map_style.go b/rule/enforce_map_style.go
@@ -70,7 +70,7 @@ func (r *EnforceMapStyleRule) Apply(file *lint.File, arguments lint.Arguments) [
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	if r.enforceMapStyle == enforceMapStyleTypeAny {

diff --git a/rule/enforce_repeated_arg_type_style.go b/rule/enforce_repeated_arg_type_style.go
@@ -106,7 +106,7 @@ func (r *EnforceRepeatedArgTypeStyleRule) Apply(file *lint.File, arguments lint.
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	if r.funcArgStyle == enforceRepeatedArgTypeStyleTypeAny && r.funcRetValStyle == enforceRepeatedArgTypeStyleTypeAny {

diff --git a/rule/enforce_slice_style.go b/rule/enforce_slice_style.go
@@ -73,7 +73,7 @@ func (r *EnforceSliceStyleRule) Apply(file *lint.File, arguments lint.Arguments)
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	if r.enforceSliceStyle == enforceSliceStyleTypeAny {

diff --git a/rule/error_strings.go b/rule/error_strings.go
@@ -58,7 +58,7 @@ func (r *ErrorStringsRule) Apply(file *lint.File, arguments lint.Arguments) []li
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/exported.go b/rule/exported.go
@@ -112,7 +112,7 @@ func (r *ExportedRule) Apply(file *lint.File, arguments lint.Arguments) []lint.F
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/file_header.go b/rule/file_header.go
@@ -39,7 +39,7 @@ func (r *FileHeaderRule) Apply(file *lint.File, arguments lint.Arguments) []lint
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	if r.header == "" {

diff --git a/rule/file_length_limit.go b/rule/file_length_limit.go
@@ -30,7 +30,7 @@ func (r *FileLengthLimitRule) Apply(file *lint.File, arguments lint.Arguments) [
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	if r.max <= 0 {

diff --git a/rule/filename_format.go b/rule/filename_format.go
@@ -23,7 +23,7 @@ func (r *FilenameFormatRule) Apply(file *lint.File, arguments lint.Arguments) []
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	filename := filepath.Base(file.Name)

diff --git a/rule/function_length.go b/rule/function_length.go
@@ -33,7 +33,7 @@ func (r *FunctionLength) Apply(file *lint.File, arguments lint.Arguments) []lint
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/function_result_limit.go b/rule/function_result_limit.go
@@ -22,7 +22,7 @@ func (r *FunctionResultsLimitRule) Apply(file *lint.File, arguments lint.Argumen
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/import_alias_naming.go b/rule/import_alias_naming.go
@@ -66,7 +66,7 @@ func (r *ImportAliasNamingRule) Apply(file *lint.File, arguments lint.Arguments)
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/imports_blocklist.go b/rule/imports_blocklist.go
@@ -48,7 +48,7 @@ func (r *ImportsBlocklistRule) Apply(file *lint.File, arguments lint.Arguments)
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/line_length_limit.go b/rule/line_length_limit.go
@@ -43,7 +43,7 @@ func (r *LineLengthLimitRule) Apply(file *lint.File, arguments lint.Arguments) [
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/max_control_nesting.go b/rule/max_control_nesting.go
@@ -24,7 +24,7 @@ func (r *MaxControlNestingRule) Apply(file *lint.File, arguments lint.Arguments)
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/max_public_structs.go b/rule/max_public_structs.go
@@ -44,7 +44,7 @@ func (r *MaxPublicStructsRule) Apply(file *lint.File, arguments lint.Arguments)
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/receiver_naming.go b/rule/receiver_naming.go
@@ -50,7 +50,7 @@ func (r *ReceiverNamingRule) Apply(file *lint.File, arguments lint.Arguments) []
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	typeReceiver := map[string]string{}

diff --git a/rule/struct_tag.go b/rule/struct_tag.go
@@ -52,7 +52,7 @@ func (r *StructTagRule) Apply(file *lint.File, arguments lint.Arguments) []lint.
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/unchecked_type_assertion.go b/rule/unchecked_type_assertion.go
@@ -51,7 +51,7 @@ func (r *UncheckedTypeAssertionRule) Apply(file *lint.File, arguments lint.Argum
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/unhandled_error.go b/rule/unhandled_error.go
@@ -47,7 +47,7 @@ func (r *UnhandledErrorRule) Apply(file *lint.File, arguments lint.Arguments) []
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/unused_param.go b/rule/unused_param.go
@@ -55,7 +55,7 @@ func (r *UnusedParamRule) Apply(file *lint.File, arguments lint.Arguments) []lin
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/unused_receiver.go b/rule/unused_receiver.go
@@ -53,7 +53,7 @@ func (r *UnusedReceiverRule) Apply(file *lint.File, arguments lint.Arguments) []
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure

diff --git a/rule/utils.go b/rule/utils.go
@@ -122,3 +122,8 @@ func isDirectiveComment(line string) bool {
 func isCallToExitFunction(pkgName, functionName string) bool {
 	return exitFunctions[pkgName] != nil && exitFunctions[pkgName][functionName]
 }
+// newInternalFailureError returns single internal failure
+func newInternalFailureError(e error) []lint.Failure {
+	return []lint.Failure{lint.NewInternalFailure(e.Error())}
+}
+
diff --git a/rule/var_naming.go b/rule/var_naming.go
@@ -96,7 +96,7 @@ func (r *VarNamingRule) Apply(file *lint.File, arguments lint.Arguments) []lint.
 	r.configureOnce.Do(func() { configureErr = r.configure(arguments) })
 
 	if configureErr != nil {
-		return []lint.Failure{lint.NewInternalFailure(configureErr.Error())}
+		return newInternalFailureError(configureErr)
 	}
 
 	var failures []lint.Failure