modifies-value-receiver: warn on slice or map (#943)

* modifies-value-receiver: warn on slice or map Assignments which index into the slice or map are already ignored on line 72, and those where the whole receiver is slice or map on line 50. We should not ignore assignments where the member variable is slice or map. Signed-off-by: Bryan Boreham <[email protected]> * Remove extra space --------- Signed-off-by: Bryan Boreham <[email protected]> Co-authored-by: Denis Voytyuk <[email protected]>
mgechev · Nov 28, 2023 · 7da6a39 · 7da6a39
1 parent 2862d06
commit 7da6a39
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/rule/modifies-value-receiver.go b/rule/modifies-value-receiver.go
@@ -78,11 +78,6 @@ func (w lintModifiesValRecRule) Visit(node ast.Node) ast.Visitor {
 					if name == "" || name != receiverName {
 						continue
 					}
-
-					if w.skipType(ast.Expr(e.Sel)) {
-						continue
-					}
-
 				case *ast.Ident: // receiver := ...
 					if e.Name != receiverName {
 						continue

diff --git a/testdata/modifies-value-receiver.go b/testdata/modifies-value-receiver.go
@@ -9,5 +9,6 @@ type data struct {
 func (this data) vmethod() {
 	this.num = 8 // MATCH /suspicious assignment to a by-value method receiver/
 	*this.key = "v.key"
+	this.items = make(map[string]bool) // MATCH /suspicious assignment to a by-value method receiver/
 	this.items["vmethod"] = true
 }