refactor (rule/function-result-limit): replace AST walker by iteratio…

…n over declarations

rule/function_result_limit.go

@@ -39,47 +39,31 @@ func (r *FunctionResultsLimitRule) Apply(file *lint.File, arguments lint.Argumen
 	r.configureOnce.Do(func() { r.configure(arguments) })
 
 	var failures []lint.Failure
+	for _, decl := range file.AST.Decls {
+		funcDecl, ok := decl.(*ast.FuncDecl)
+		if !ok {
+			continue
+		}
 
-	walker := lintFunctionResultsNum{
-		max: r.max,
-		onFailure: func(failure lint.Failure) {
-			failures = append(failures, failure)
-		},
-	}
-
-	ast.Walk(walker, file.AST)
-
-	return failures
-}
-
-// Name returns the rule name.
-func (*FunctionResultsLimitRule) Name() string {
-	return "function-result-limit"
-}
-
-type lintFunctionResultsNum struct {
-	max       int
-	onFailure func(lint.Failure)
-}
-
-func (w lintFunctionResultsNum) Visit(n ast.Node) ast.Visitor {
-	node, ok := n.(*ast.FuncDecl)
-	if ok {
 		num := 0
-		hasResults := node.Type.Results != nil
+		hasResults := funcDecl.Type.Results != nil
 		if hasResults {
-			num = node.Type.Results.NumFields()
+			num = funcDecl.Type.Results.NumFields()
 		}
-		if num > w.max {
-			w.onFailure(lint.Failure{
+
+		if num > r.max {
+			failures = append(failures, lint.Failure{
 				Confidence: 1,
-				Failure:    fmt.Sprintf("maximum number of return results per function exceeded; max %d but got %d", w.max, num),
-				Node:       node.Type,
+				Failure:    fmt.Sprintf("maximum number of return results per function exceeded; max %d but got %d", r.max, num),
+				Node:       funcDecl.Type,
 			})
 		}
-
-		return nil // skip visiting function's body
 	}
 
-	return w
+	return failures
+}
+
+// Name returns the rule name.
+func (*FunctionResultsLimitRule) Name() string {
+	return "function-result-limit"
 }