Simplify Qt multimedia code #3438
Conversation
There was a problem hiding this comment.
While this does arguably simplify the AudioProcessorQt code, it does this by making a device and then effectively immediately deleting it as soon as the settings get applied. I'm not sure that's really a worthwhile change.
Further, I'm not sure the camera code is really simplified. You removed a variable, but in the process introduced the same setup-teardown-setup cycle. Also, we really don't want to create a camera early. There's no reason to instantiate one 99.9% of the time.
| @@ -1343,6 +1343,8 @@ static uint8_t _readLuminance(struct GBALuminanceSource* luminance) { | |||
| } | |||
| #endif | |||
|
|
|||
| #pragma push_macro("CALLBACK") | |||
There was a problem hiding this comment.
I have no idea what warning this fixes. Is it Windows-specific? Regardless, it doesn't belong in this PR.
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.3) | |||
| cmake_minimum_required(VERSION 3.10) | |||
There was a problem hiding this comment.
Please rebase. I made this change a few days ago so it's not needed anymore.
|
Yes, it's probably not worth it. |
I think the unique pointers in
InputControllerandAudioProcessorQtare unnecessary. I have refactored the code to not use unique pointers and simplified the code.