Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line option to specify URL schema override for XmlSchemaSet #535

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

phoyd
Copy link
Contributor

@phoyd phoyd commented Nov 23, 2024

See #534. Makes XmlSchemaSet resolve URLs that differ only by schema prefix (http: and https: for example) as the same URL.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.10%. Comparing base (e44cd71) to head (1afc95e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
XmlSchemaClassGenerator/Generator.cs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   94.08%   94.10%   +0.01%     
==========================================
  Files          21       21              
  Lines        3164     3187      +23     
  Branches      496      497       +1     
==========================================
+ Hits         2977     2999      +22     
- Misses        122      123       +1     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mganss
Copy link
Owner

mganss commented Nov 25, 2024

Thanks! Could you add a quick unit test?

@mganss mganss merged commit 816306c into mganss:master Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants